From: Junio C Hamano <gitster@pobox.com>
To: Jonathan del Strother <maillist@steelskies.com>
Cc: Jens Lehmann <Jens.Lehmann@web.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: v1.7.0-rc0 shows lots of "unable to find <sha1>" on git-stash
Date: Sat, 30 Jan 2010 12:25:56 -0800 [thread overview]
Message-ID: <7vvdejmjaj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7v8wbfnyz9.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sat\, 30 Jan 2010 12\:01\:46 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Please try this.
oops, but with this, too.
> diff --git a/submodule.c b/submodule.c
> index ca0527f..8bd0a30 100644
> --- a/submodule.c
> +++ b/submodule.c
> ...
> @@ -142,7 +142,9 @@ int is_submodule_modified(const char *path)
> env[0] = strbuf_detach(&buf, NULL);
> strbuf_addf(&buf, "GIT_DIR=%s/.git", path);
> env[1] = strbuf_detach(&buf, NULL);
> - env[2] = NULL;
> + strbuf_addf(&buf, "GIT_INDEX_FILE=");
This should be:
strbuf_addf(&buf, "GIT_INDEX_FILE");
> + env[2] = strbuf_detach(&buf, NULL);
> + env[3] = NULL;
>
> memset(&cp, 0, sizeof(cp));
> cp.argv = argv;
next prev parent reply other threads:[~2010-01-30 20:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 15:12 v1.7.0-rc0 shows lots of "unable to find <sha1>" on git-stash Jonathan del Strother
[not found] ` <7vzl3wiz59.fsf@alter.siamese.dyndns.org>
2010-01-30 0:46 ` Jonathan del Strother
2010-01-30 12:31 ` Jens Lehmann
2010-01-30 13:23 ` Jonathan del Strother
2010-01-30 14:10 ` Jens Lehmann
2010-01-30 16:36 ` Jonathan del Strother
2010-01-30 20:01 ` Junio C Hamano
2010-01-30 20:25 ` Junio C Hamano [this message]
2010-01-30 20:30 ` [PATCH] is_submodule_modified(): fix breakage with external GIT_INDEX_FILE Junio C Hamano
2010-01-31 19:16 ` v1.7.0-rc0 shows lots of "unable to find <sha1>" on git-stash Jonathan del Strother
2010-01-31 19:21 ` Jonathan del Strother
2010-01-31 19:21 ` Junio C Hamano
2010-01-30 20:44 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdejmjaj.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=maillist@steelskies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).