From: Junio C Hamano <gitster@pobox.com>
To: David Aguilar <davvid@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH 2/3] difftool: Add '-x' and as an alias for '--extcmd'
Date: Fri, 15 Jan 2010 11:46:32 -0800 [thread overview]
Message-ID: <7vvdf3xiav.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1263539762-8269-2-git-send-email-davvid@gmail.com> (David Aguilar's message of "Thu\, 14 Jan 2010 23\:16\:01 -0800")
David Aguilar <davvid@gmail.com> writes:
> -# Copyright (c) 2009 David Aguilar
> +# Copyright (c) 2009-2010 David Aguilar
Just a very minor issue. I'd prefer to see:
Copyright (c) 2008, 2009, 2010
over
Copyright (c) 2008-2010
Copyright lawyers may say parenthesized-c does not have any legal meaning
and must be circle-c, but I am not a lawyer.
next prev parent reply other threads:[~2010-01-15 19:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 7:16 [PATCH 1/3] t7800-difftool.sh: Simplify the --extcmd test David Aguilar
2010-01-15 7:16 ` [PATCH 2/3] difftool: Add '-x' and as an alias for '--extcmd' David Aguilar
2010-01-15 19:46 ` Junio C Hamano [this message]
2010-01-15 19:54 ` Bill Lear
2010-01-16 1:05 ` Junio C Hamano
2010-01-16 13:44 ` Bill Lear
2010-01-15 7:16 ` [PATCH 3/3] difftool: Use eval to expand '--extcmd' expressions David Aguilar
2010-01-15 8:40 ` Johannes Sixt
2010-01-15 17:59 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdf3xiav.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).