From: Junio C Hamano <gitster@pobox.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: "Jan Krüger" <jk@jk.gs>, "Git ML" <git@vger.kernel.org>,
"Sverre Rabbelier" <srabbelier@gmail.com>
Subject: Re: [PATCH RFC v2] builtin-push: add --delete as syntactic sugar for :foo
Date: Tue, 29 Dec 2009 08:58:29 -0800 [thread overview]
Message-ID: <7vvdfpg1je.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20091229200523.6117@nanako3.lavabit.com
Nanako Shiraishi <nanako3@lavabit.com> writes:
> Junio, could you tell us what happened to this thread?
>
> The patch implements "git push repo --delete branch" and rejects
> --delete used with other options like --all and --tags, as suggested in
> the initial review. I think it makes sense, but nothing happens after
> that.
Sverre cited an old discussion and the discussion stalled. I just re-read
the thread, and think the "this is a wrong idea" objection was primarily
about allowing --delete with non-delete kinds of refspecs, so in that
sense Jan's patch is a perfected form of the Sverre's patch from that old
discussion.
As a summary of the lesson learned and concensus from the old discussion,
I agree with this from Sverre:
http://article.gmane.org/gmane.comp.version-control.git/125901
namely, (1) barf and abort if src:dst is given; (2) touch only refs given
from the command line, "push there --delete" without any refspec is an
error; (3) be careful about "git push there tag v1.0.0" form.
So if Jan or Sverre want to resurrect the topic, I am all for it.
next prev parent reply other threads:[~2009-12-29 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 12:09 [PATCH RFC] builtin-push: add --delete as syntactic sugar for :foo Jan Krüger
2009-11-09 16:59 ` Junio C Hamano
2009-11-09 17:08 ` Junio C Hamano
2009-11-09 17:20 ` Sverre Rabbelier
2009-11-09 18:20 ` [PATCH RFC v2] " Jan Krüger
2009-12-29 11:05 ` Nanako Shiraishi
2009-12-29 16:58 ` Junio C Hamano [this message]
2009-12-30 9:52 ` [PATCH v3] " Jan Krüger
2009-12-30 12:14 ` Sverre Rabbelier
2009-12-30 19:49 ` Junio C Hamano
2009-12-30 19:57 ` [PATCH v4] " Jan Krüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdfpg1je.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jk@jk.gs \
--cc=nanako3@lavabit.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).