Re: [REROLL PATCH v2 6/8] Support remote helpers implementing smart transports

[Junio C Hamano <gitster@pobox.com>]

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Ilari Liusvaara <ilari.liusvaara@elisanet.fi> wrote:
>> Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
>
> This is better.

Is this sarcasm?

As far as I can tell, there is no "Junio received and added some that is
copyrightable, and Ilari later received it and worked on it" anywhere in
this series to require recording of patch ping-pong, except perhaps 3/8
where I gave remove_ext_force() with a shorter implementation.  The only
edit I did myself was to fix style.

I did suggest renaming a few functions but that (1) eventually was done by
Ilari, and (2) isn't large enough change to be copyrightable, I think.

>> +	if (strcmp(name, exec)) {
>> +		r = set_helper_option(transport, "servpath", exec);
>> +		if (r > 0)
>> +			fprintf(stderr, "Warning: Setting remote service path "
>> +				"not supported by protocol.\n");
>> +		else if (r < 0)
>> +			fprintf(stderr, "Warning: Invalid remote service "
>> +				"path.\n");
>
> Style-nit: We prefer "warning: " with lowercase.

Also this could be a semantic nit; we prefer to call warning(), which is
meant to be overridable by the main program (it probably does not matter,
though).