From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 6/8] archive: use index instead of parsing tree directly Date: Wed, 08 Apr 2009 12:20:48 -0700 Message-ID: <7vvdpfj6jz.fsf@gitster.siamese.dyndns.org> References: <1239185133-4181-1-git-send-email-pclouds@gmail.com> <1239185133-4181-2-git-send-email-pclouds@gmail.com> <1239185133-4181-3-git-send-email-pclouds@gmail.com> <1239185133-4181-4-git-send-email-pclouds@gmail.com> <1239185133-4181-5-git-send-email-pclouds@gmail.com> <1239185133-4181-6-git-send-email-pclouds@gmail.com> <1239185133-4181-7-git-send-email-pclouds@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org To: =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy X-From: git-owner@vger.kernel.org Wed Apr 08 21:22:35 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LrdM1-0001Or-Pc for gcvg-git-2@gmane.org; Wed, 08 Apr 2009 21:22:34 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760506AbZDHTUz convert rfc822-to-quoted-printable (ORCPT ); Wed, 8 Apr 2009 15:20:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764505AbZDHTUy (ORCPT ); Wed, 8 Apr 2009 15:20:54 -0400 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:55026 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764499AbZDHTUy convert rfc822-to-8bit (ORCPT ); Wed, 8 Apr 2009 15:20:54 -0400 Received: from localhost.localdomain (unknown [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 78DF4A84C1; Wed, 8 Apr 2009 15:20:53 -0400 (EDT) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 4CD01A84BB; Wed, 8 Apr 2009 15:20:49 -0400 (EDT) User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 60B02BA2-2472-11DE-BAFF-BB14ECB1AA3C-77302942!a-sasl-fastnet.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy writes: > Currently: > > - "git archive" parses trees directly > - attr mechanism does not support in-tree attributes > > Making attr.c support in-tree attributes is quite a non-trivial task, > IMHO. Instead this patch makes "git archive" read tree to index first= , > then start exporting from there. > > One minor regression: "git archive" now will no longer generate > directory entries, only files. Hmmm, if you read_tree() into the_index upfront and do not change anyth= ing else to the archive.c code, shouldn't it work without such a regression= at all? Am I missing something? It would allow you to export the index into an archive, but I doubt it = is worth the amount of code churn.