git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: martin f krafft <madduck@madduck.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Brian Campbell" <brian.p.campbell@dartmouth.edu>,
	git@vger.kernel.org, "Petr Baudis" <pasky@suse.cz>
Subject: Re: [PATCH 2/2] [TopGit] Portability: Don't use alternation ("|") in sed regular expressions
Date: Fri, 13 Mar 2009 22:54:41 -0700	[thread overview]
Message-ID: <7vvdqcejj2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090312152630.GA26379@piper.oerlikon.madduck.net

martin f krafft <madduck@madduck.net> writes:

> also sprach Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [2009.03.12.1620 +0100]:
>> IMHO we should reuse as much as possible from git.git.  For me even
>> requiring a git.git checkout to use its files would be OK.  I consider
>> that even better then duplicating the relevant files.
>
> Maybe we could even start to think about integrating TopGit back
> into git.git?

Heh, it would need massive style fixes before that happens. I am fairly
picky on shell script styles.

  reply	other threads:[~2009-03-14  5:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12  5:56 [PATCH 1/2] [TopGit] Portability: Use tr instead of sed for translating spaces to newlines Brian Campbell
2009-03-12  5:56 ` [PATCH 2/2] [TopGit] Portability: Don't use alternation ("|") in sed regular expressions Brian Campbell
2009-03-12  6:55   ` Junio C Hamano
2009-03-12  7:45     ` Uwe Kleine-König
2009-03-12 15:00       ` Brian Campbell
2009-03-12 15:20         ` Uwe Kleine-König
2009-03-12 15:26           ` martin f krafft
2009-03-14  5:54             ` Junio C Hamano [this message]
2009-03-14 12:47               ` Uwe Kleine-König
2009-03-12 16:41           ` Brian Campbell
2009-03-12 17:04             ` Uwe Kleine-König
2009-03-12 15:09   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvdqcejj2.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=brian.p.campbell@dartmouth.edu \
    --cc=git@vger.kernel.org \
    --cc=madduck@madduck.net \
    --cc=pasky@suse.cz \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).