From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] filter-branch: do not consider diverging submodules a 'dirty worktree'
Date: Wed, 04 Feb 2009 10:00:11 -0800 [thread overview]
Message-ID: <7vvdrqt74k.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <4989CF79.2070209@viscovery.net> (Johannes Sixt's message of "Wed, 04 Feb 2009 18:25:13 +0100")
Johannes Sixt <j.sixt@viscovery.net> writes:
> Because if the repository is non-bare, then filter-branch updates the
> work-tree at the end of the run; we don't want to overwrite uncommitted
> work in this case.
>
> This behavior is a relic from cg-admin-rewritehist, I think. I've never
> found it useful.
Ok, I think "read-tree -m -u HEAD" at the end sort of makes sense, if you
filtered the branch you are currently sitting on. Does that mean we do
not have to barf on dirtyness if we can tell if the filter-branch will not
touch the current branch at all? Again, I am not suggesting it as an
improvement, but I am trying to see if I am talking a total nonsense.
Is the reason why you haven't found it is useful is because you never
filter the current branch?
next prev parent reply other threads:[~2009-02-04 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1233758410u.git.johannes.schindelin@gmx.de>
2009-02-04 14:40 ` [PATCH] filter-branch: do not consider diverging submodules a 'dirty worktree' Johannes Schindelin
2009-02-04 17:17 ` Junio C Hamano
2009-02-04 17:24 ` Johannes Schindelin
2009-02-04 17:25 ` Johannes Sixt
2009-02-04 18:00 ` Junio C Hamano [this message]
2009-02-04 18:15 ` Johannes Schindelin
2009-02-04 18:57 ` Junio C Hamano
2009-02-05 17:39 ` Johannes Schindelin
2009-02-05 6:49 ` Johannes Sixt
[not found] <cover.1233855372u.git.johannes.schindelin@gmx.de>
2009-02-05 17:37 ` Johannes Schindelin
2009-02-05 17:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdrqt74k.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).