From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] bash: offer to show (un)staged changes
Date: Sat, 17 Jan 2009 18:13:48 -0800 [thread overview]
Message-ID: <7vvdsd1hur.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1232240184-10906-1-git-send-email-trast@student.ethz.ch> (Thomas Rast's message of "Sun, 18 Jan 2009 01:56:24 +0100")
Thomas Rast <trast@student.ethz.ch> writes:
> I came up with this after sending two incomplete patches on the same
> night, and really like it. Perhaps others might find it useful.
Any patch worth discussing (on this list at least) would need a nontrivial
commit log message that you need to really think while writing. It is
natural to assume people would be making them with their editor, not with
"commit -m". These two incomplete patches could have been avoided if you
paid attention to the status output that is in the commit log message
buffer. Perhaps we should make it even louder in some way?
next prev parent reply other threads:[~2009-01-18 2:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 0:56 [PATCH] bash: offer to show (un)staged changes Thomas Rast
2009-01-18 1:53 ` Junio C Hamano
2009-01-18 2:06 ` Thomas Rast
2009-01-19 17:29 ` Shawn O. Pearce
2009-01-19 18:00 ` Martin Langhoff
2009-01-19 18:11 ` Shawn O. Pearce
2009-01-19 18:28 ` Mike Hommey
2009-01-19 18:42 ` Martin Langhoff
2009-01-19 19:06 ` Boyd Stephen Smith Jr.
2009-01-19 19:12 ` Martin Langhoff
2009-01-19 19:01 ` Boyd Stephen Smith Jr.
2009-01-19 21:38 ` [PATCH v2] " Thomas Rast
2009-02-01 22:13 ` Thomas Rast
2009-02-01 22:29 ` Shawn O. Pearce
2009-02-03 9:20 ` [PATCH v3] " Thomas Rast
2009-02-03 18:11 ` Shawn O. Pearce
2009-02-01 22:48 ` [PATCH] " Tuncer Ayaz
2009-02-01 23:43 ` Junio C Hamano
2009-02-02 0:50 ` Tuncer Ayaz
2009-02-02 19:31 ` Tuncer Ayaz
2009-01-18 2:13 ` Junio C Hamano [this message]
2009-01-18 2:32 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdsd1hur.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).