git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ted Pavlic <ted@tedpavlic.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] Purest update to bash completions to prevent unbounded variable errors.
Date: Tue, 13 Jan 2009 11:43:53 -0800	[thread overview]
Message-ID: <7vvdsj6lfq.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <496CC3E7.8060805@tedpavlic.com> (Ted Pavlic's message of "Tue, 13 Jan 2009 11:40:07 -0500")

Ted Pavlic <ted@tedpavlic.com> writes:

>> Your commit message leaves a lot to be desired.  I would instead
>> have written something like this:
>
> I agree completely. Sorry about that. stg fired off vim to edit the
> commit message, and I just wasn't thinking.
>
> Would you like me to modify the commit message and resubmit?

Luckily or unluckily, you need to do that anyway, as your patches are
whitespace damaged.

Please don't send "format=flowed".

  parent reply	other threads:[~2009-01-13 19:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 16:08 [PATCH 1/3] Purest update to bash completions to prevent unbounded variable errors Ted Pavlic
2009-01-13 16:34 ` Shawn O. Pearce
2009-01-13 16:40   ` Ted Pavlic
2009-01-13 16:46     ` Shawn O. Pearce
2009-01-13 19:43     ` Junio C Hamano [this message]
2009-01-14 20:08       ` Ted Pavlic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvdsj6lfq.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    --cc=ted@tedpavlic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).