git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, git@vger.kernel.org
Subject: Re: email address handling
Date: Fri, 01 Aug 2008 14:50:05 -0700	[thread overview]
Message-ID: <7vvdykqub6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080801135421.5ca0f6af.akpm@linux-foundation.org> (Andrew Morton's message of "Fri, 1 Aug 2008 13:54:21 -0700")

Andrew Morton <akpm@linux-foundation.org> writes:

>> The part _you_ don't seem to understand is that my point is
>> 
>>  - git changed that "From:" line to an "Author:" line
>> 
>>  - "git log" isn't an email system. It's a human-readable (and 
>>    machine-parseable, for that matter) log.
>
> What you're describing here is some explicit or implicit git design
> decision and then telling me how it's implemented.
>
> Well, what I'm saying is that it was an incorrect design decision.

What is the objective of your statement in this discussion?  Further add
fuel to flame, or to seek avenues that lead to some improvement in a
constructive way?

The thing is, I do not think reverting that design decision is an option
at this point.  People's repositories record <Name, Email> pair already in
"human readable" form, and people's scripts are assuming that.

I misspoke about git-send-email earlier; it already has sanitize_address()
that massages the addresses on From: To: and Cc: lines.  In fact, it even
seems to have logic to avoid double-quoting, so it would be Ok if you
changed the design decision this late in the game for that particular
script, but that does not mean it is a good change --- other scripts
people may have built around git would need to change.

So the earlier patch from Dscho (Johannes) may be a step in the right
direction, but if we are going to rewrite the author information, (1) it
has to be an option, and (2) when rewriting, it should not be just From:;
but Signed-off-by:, Cc: and other <Name, Email> pairs at the end of the
log message would need similar treatment, so that you can cut and paste
any of them to your MUA.

  parent reply	other threads:[~2008-08-01 21:51 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01  2:40 email address handling Andrew Morton
2008-08-01 19:34 ` Linus Torvalds
2008-08-01 19:45   ` Andrew Morton
2008-08-01 19:56     ` Linus Torvalds
2008-08-01 20:07       ` Junio C Hamano
2008-08-01 20:11       ` Andrew Morton
2008-08-01 20:17         ` Linus Torvalds
2008-08-01 20:24           ` Andrew Morton
2008-08-01 20:40             ` Linus Torvalds
2008-08-01 20:41               ` Linus Torvalds
2008-08-01 20:54               ` Andrew Morton
2008-08-01 21:12                 ` Linus Torvalds
2008-08-01 21:16                 ` Johannes Schindelin
2008-08-01 21:25                   ` Junio C Hamano
2008-08-02 11:03                     ` Johannes Schindelin
2008-08-01 21:50                 ` Junio C Hamano [this message]
2008-08-01 21:58                   ` Andrew Morton
2008-08-01 22:15                     ` Theodore Tso
2008-08-01 22:27                       ` Andrew Morton
2008-08-01 22:34                         ` Linus Torvalds
2008-08-01 22:44                           ` Andrew Morton
2008-08-01 22:52                             ` Linus Torvalds
2008-08-01 23:00                               ` Andrew Morton
2008-08-01 22:49                           ` Linus Torvalds
2008-08-04 20:14                             ` Karl Hasselström
2008-08-01 22:39                         ` Linus Torvalds
2008-08-01 22:49                           ` Andrew Morton
2008-08-01 22:55                             ` Linus Torvalds
2008-08-01 23:16                               ` Linus Torvalds
2008-08-02 11:31                                 ` Johannes Schindelin
2008-08-02 16:20                                   ` Linus Torvalds
2008-08-02 16:36                                     ` Junio C Hamano
2008-08-02 16:59                                       ` Johannes Schindelin
2008-08-02 17:08                                         ` Linus Torvalds
2008-08-02 16:40                                     ` Junio C Hamano
2008-08-02 16:42                                       ` Junio C Hamano
2008-08-02 17:50                                     ` Junio C Hamano
2008-08-01 22:23                     ` Linus Torvalds
2008-08-01 22:41                       ` Andrew Morton
2008-08-01 20:00     ` Junio C Hamano
2008-08-01 20:14       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvdykqub6.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=akpm@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).