git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stephan Beyer <s-beyer@gmx.net>
Cc: Brandon Casey <casey@nrlssc.navy.mil>, git@vger.kernel.org
Subject: Re: [PATCH] Set TAR in t/Makefile and in t4116-apply-reverse.sh
Date: Fri, 25 Jul 2008 11:18:52 -0700	[thread overview]
Message-ID: <7vvdytsu7n.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1217003860-10609-1-git-send-email-s-beyer@gmx.net

Actually, 455a7f3 (More portability., 2005-09-30) introduced $TAR and it
is also used in t5000.  cb34882 (fix t5000-tar-tree.sh when $TAR isn't
set, 2005-11-08) did the same fix you are adding, but I think both of
these fixes are in a wrong place.

I think we should do this instead.  That's how SHELL_PATH is passed around
from build to all the test scripts already.

---
 Makefile            |    1 +
 t/t5000-tar-tree.sh |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index b003e3e..1d14209 100644
--- a/Makefile
+++ b/Makefile
@@ -1212,6 +1212,7 @@ GIT-CFLAGS: .FORCE-GIT-CFLAGS
 
 GIT-BUILD-OPTIONS: .FORCE-GIT-BUILD-OPTIONS
 	@echo SHELL_PATH=\''$(SHELL_PATH_SQ)'\' >$@
+	@echo TAR=\''$(subst ','\'',$(TAR))'\' >>$@
 
 ### Detect Tck/Tk interpreter path changes
 ifndef NO_TCLTK
diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
index 9b0baac..5eb119e 100755
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -25,7 +25,6 @@ commit id embedding:
 '
 
 . ./test-lib.sh
-TAR=${TAR:-tar}
 UNZIP=${UNZIP:-unzip}
 
 SUBSTFORMAT=%H%n

  parent reply	other threads:[~2008-07-25 18:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0GfECozN3g0ZvAESKMi76RyOVHEb2OhhwET9GWmEm7pbzYQJub50UlWpZtBa7MGn1UGb-7mzbzE@cipher.nrlssc.navy.mil>
2008-07-22 21:15 ` [PATCH] perl/Makefile: update NO_PERL_MAKEMAKER section Brandon Casey
2008-07-22 23:09   ` Petr Baudis
2008-07-23 16:22     ` Brandon Casey
2008-07-23 23:29   ` Junio C Hamano
2008-07-23 23:56     ` Brandon Casey
2008-07-22 21:16 ` [PATCH] t9700/test.pl: backwards compatibility improvements Brandon Casey
2008-07-23 23:33   ` Junio C Hamano
2008-07-24  0:08     ` Brandon Casey
2008-07-22 21:16 ` [PATCH] t4116-apply-reverse.sh: use $TAR rather than tar Brandon Casey
2008-07-25 16:37   ` [PATCH] Set TAR in t/Makefile and in t4116-apply-reverse.sh Stephan Beyer
2008-07-25 17:05     ` Miklos Vajna
2008-07-25 17:12       ` Stephan Beyer
2008-07-25 18:18     ` Junio C Hamano [this message]
2008-07-25 18:24       ` Stephan Beyer
2008-07-25 18:54         ` Junio C Hamano
2008-07-25 18:58           ` Stephan Beyer
2008-07-25 19:37             ` Junio C Hamano
2008-07-22 21:16 ` [PATCH] t3200,t7201: replace '!' with test_must_fail Brandon Casey
2008-07-22 21:17 ` [PATCH] t/: Replace diff [-u|-U0] with test_cmp to allow compilation with old diff Brandon Casey
2008-07-24  0:19   ` Miklos Vajna
2008-07-24  0:55     ` Brandon Casey
2008-07-22 21:21 ` [PATCH] t7502-commit.sh: rearrange test to make more portable Brandon Casey
2008-07-22 21:23 ` [PATCH] t/t4202-log.sh: add newline at end of file Brandon Casey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvdytsu7n.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=s-beyer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).