From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Stephan Beyer <s-beyer@gmx.net>, git@vger.kernel.org
Subject: Re: [PATCH] editor.c: Libify launch_editor()
Date: Fri, 25 Jul 2008 01:36:53 -0700 [thread overview]
Message-ID: <7vvdyuuzq2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.DEB.1.00.0807181405510.3932@eeepc-johanness
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi,
>
> On Fri, 18 Jul 2008, Stephan Beyer wrote:
>
>> This patch removes exit()/die() calls and builtin-specific messages from
>> launch_editor(), so that it can be used as a general libgit.a function
>> to launch an editor.
>
> Thanks. Now we have to convince Junio that it is a good idea :-)
Eh, excuse me.
>> diff --git a/editor.c b/editor.c
>> index 483b62d..5d7f5f9 100644
>> --- a/editor.c
>> +++ b/editor.c
>> @@ -17,9 +17,8 @@ void launch_editor(const char *path, struct strbuf *buffer, const char *const *e
> ...
> Why not "return error()"?
>
> Rest looks obviously correct to me!
This is a patch to an existing file editor.c???
next prev parent reply other threads:[~2008-07-25 8:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 0:36 [PATCH] Move launch_editor() from builtin-tag.c to editor.c Stephan Beyer
2008-07-18 1:14 ` Johannes Schindelin
2008-07-18 1:26 ` Stephan Beyer
2008-07-18 11:26 ` [PATCH] editor.c: Libify launch_editor() Stephan Beyer
2008-07-18 12:07 ` Johannes Schindelin
2008-07-18 12:35 ` [PATCH v2] " Stephan Beyer
2008-07-23 23:09 ` [PATCH] " Stephan Beyer
2008-07-24 1:48 ` Stephan Beyer
2008-07-25 8:36 ` Junio C Hamano [this message]
2008-07-25 10:28 ` Johannes Schindelin
2008-07-25 14:15 ` Stephan Beyer
2008-07-25 14:36 ` Johannes Schindelin
2008-07-25 16:28 ` [PATCH 1/2] Move launch_editor() from builtin-tag.c to editor.c Stephan Beyer
2008-07-25 16:28 ` [PATCH 2/2] editor.c: Libify launch_editor() Stephan Beyer
2008-07-25 17:16 ` Stephan Beyer
2008-07-26 3:00 ` [PATCH 1/2] Move launch_editor() from builtin-tag.c to editor.c Johannes Schindelin
2008-07-26 3:14 ` Stephan Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdyuuzq2.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).