From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and
 /etc/gitconfig
Date: Fri, 27 Jun 2008 15:40:48 -0700
Message-ID: <7vvdzuo61b.fsf@gitster.siamese.dyndns.org>
References: <27C25D70-0BFC-4362-A771-C7CAD89BC198@ai.rug.nl>
 <alpine.DEB.1.00.0806271353350.9925@racer>
 <alpine.LNX.1.00.0806271149580.19665@iabervon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Pieter de Bie <pdebie@ai.rug.nl>,
	Git Mailinglist <git@vger.kernel.org>
To: Daniel Barkalow <barkalow@iabervon.org>
X-From: git-owner@vger.kernel.org Sat Jun 28 00:42:08 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1KCMdq-0001Ig-LO
	for gcvg-git-2@gmane.org; Sat, 28 Jun 2008 00:42:07 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755573AbYF0WlJ (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Fri, 27 Jun 2008 18:41:09 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755743AbYF0WlI
	(ORCPT <rfc822;git-outgoing>); Fri, 27 Jun 2008 18:41:08 -0400
Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:43937 "EHLO
	sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753597AbYF0WlF (ORCPT <rfc822;git@vger.kernel.org>);
	Fri, 27 Jun 2008 18:41:05 -0400
Received: from localhost.localdomain (localhost [127.0.0.1])
	by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 1B816DB3D;
	Fri, 27 Jun 2008 18:41:04 -0400 (EDT)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client
 certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with
 ESMTPSA id 4934ADB3C; Fri, 27 Jun 2008 18:40:58 -0400 (EDT)
In-Reply-To: <alpine.LNX.1.00.0806271149580.19665@iabervon.org> (Daniel
 Barkalow's message of "Fri, 27 Jun 2008 12:05:39 -0400 (EDT)")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
X-Pobox-Relay-ID: 1FD9CA60-449A-11DD-B092-CE28B26B55AE-77302942!a-sasl-fastnet.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/86669>

Daniel Barkalow <barkalow@iabervon.org> writes:

> On Fri, 27 Jun 2008, Johannes Schindelin wrote:
>
>> After initializing the config in the newly-created repository, we
>> need to unset GIT_CONFIG so that the global configs are read again.
>
> This seems fine to me. OTOH, I'm not sure the environment variable should 
> be needed in the first place; I think the config stuff should look in 
> git_path("config") without it, and we set the git dir to the one we're 
> initializing. So I think the use of the environment variable is just an 
> artifact of how the shell script did it and how I was originally calling 
> the init_db stuff.
>
> Just removing the "setenv()" line survives all of the tests for me, and I 
> remember some of them failing before I'd gotten some sort of solution for 
> the config stuff.

Ok, I take that you are Ok with 2/2 but you have a better replacement
patch coming for this 1/2?