From: Junio C Hamano <gitster@pobox.com>
To: しらいしななこ <nanako3@bluebottle.com>
Cc: Boyd Lynn Gerber <gerberb@zenez.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] progress.c: avoid use of dynamic-sized array
Date: Sun, 08 Jun 2008 15:02:16 -0700 [thread overview]
Message-ID: <7vve0jh9g7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 200806082151.m58Lp6sG014324@mi0.bluebottle.com
しらいしななこ <nanako3@bluebottle.com> writes:
> Quoting Boyd Lynn Gerber <gerberb@zenez.com>:
>
>> Dynamically sized arrays are gcc and C99 construct. Using them hurts
>> portability to older compilers, although using them is nice in this case
>> it is not desirable. This patch removes the only use of the construct
>> in stop_progress_msg(); the function is about writing out a single line
>> of a message, and the existing callers of this function feed messages
>> of only bounded size anyway, so use of dynamic array is simply overkill.
>>
>> Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com>
>
> I may be mistaken but isn't this Junio's patch? If so (quoting
> from SubmittingPatches document):
>
> If you are forwarding a patch from somebody else, optionally, at
> the beginning of the e-mail message just before the commit
> message starts, you can put a "From: " line to name that person.
Heh, thanks for being picky ;-)
Something this small, either way is fine by me. Besides, I've applied the
patch (and the other one) from Boyd already.
next prev parent reply other threads:[~2008-06-08 22:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 15:26 [PATCH] progress.c: avoid use of dynamic-sized array Boyd Lynn Gerber
2008-06-08 19:30 ` Johannes Schindelin
2008-06-08 19:52 ` Boyd Lynn Gerber
2008-06-08 21:34 ` Alex Riesen
2008-06-08 21:50 ` しらいしななこ
2008-06-08 22:02 ` Junio C Hamano [this message]
[not found] ` <200806082151.m58Lp6sH014324@mi0.bluebottle.com>
2008-06-08 21:53 ` Boyd Lynn Gerber
-- strict thread matches above, loose matches on Subject: below --
2008-06-08 15:28 [PATCH] Port to 12 other Platforms Boyd Lynn Gerber
2008-06-08 15:46 ` Jakub Narebski
2008-06-08 16:04 ` Boyd Lynn Gerber
2008-06-08 18:52 ` Junio C Hamano
2008-06-08 20:47 ` Boyd Lynn Gerber
2008-06-08 21:19 ` Junio C Hamano
2008-06-08 21:37 ` [PATCH] progress.c: avoid use of dynamic-sized array Boyd Lynn Gerber
2008-06-06 19:34 [PATCH] This patch is to allow 12 different OS's to compile and run git Boyd Lynn Gerber
2008-06-06 19:39 ` Jeremy Maitin-Shepard
2008-06-06 20:02 ` Boyd Lynn Gerber
2008-06-06 23:08 ` Junio C Hamano
2008-06-06 23:23 ` Boyd Lynn Gerber
2008-06-07 0:38 ` [PATCH] 0002 " Boyd Lynn Gerber
2008-06-07 0:47 ` Daniel Barkalow
2008-06-07 1:25 ` [PATCH] 0003 " Boyd Lynn Gerber
2008-06-07 2:12 ` Junio C Hamano
2008-06-07 2:40 ` Boyd Lynn Gerber
2008-06-07 3:40 ` Daniel Barkalow
2008-06-08 3:46 ` Boyd Lynn Gerber
2008-06-08 7:45 ` Junio C Hamano
2008-06-08 16:57 ` [PATCH] progress.c: avoid use of dynamic-sized array Boyd Lynn Gerber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve0jh9g7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=gerberb@zenez.com \
--cc=git@vger.kernel.org \
--cc=nanako3@bluebottle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox