From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Make the exit code of add_file_to_index actually useful Date: Mon, 12 May 2008 16:32:19 -0700 Message-ID: <7vve1jw130.fsf@gitster.siamese.dyndns.org> References: <47C95E34.1050306@dirk.my1.cc> <20080302154154.GC2973@steel.home> <20080302154238.GD2973@steel.home> <7vtzjpoye6.fsf@gitster.siamese.dyndns.org> <20080512175654.GB3128@steel.home> <7vzlqvxt1p.fsf@gitster.siamese.dyndns.org> <20080512205414.GH3128@steel.home> <7viqxjxj0h.fsf@gitster.siamese.dyndns.org> <20080512224844.GI3128@steel.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Johannes Schindelin , Dirk =?utf-8?Q?S?= =?utf-8?Q?=C3=BCsserott?= , Git Mailing List To: Alex Riesen X-From: git-owner@vger.kernel.org Tue May 13 01:33:38 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JvhWQ-0003rr-KK for gcvg-git-2@gmane.org; Tue, 13 May 2008 01:33:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754380AbYELXca (ORCPT ); Mon, 12 May 2008 19:32:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754344AbYELXca (ORCPT ); Mon, 12 May 2008 19:32:30 -0400 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:40672 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbYELXca (ORCPT ); Mon, 12 May 2008 19:32:30 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 9244A5539; Mon, 12 May 2008 19:32:27 -0400 (EDT) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id C11895535; Mon, 12 May 2008 19:32:22 -0400 (EDT) In-Reply-To: <20080512224844.GI3128@steel.home> (Alex Riesen's message of "Tue, 13 May 2008 00:48:44 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: AEBFF49A-207B-11DD-A7DB-80001473D85F-77302942!a-sasl-fastnet.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Alex Riesen writes: > Junio C Hamano, Tue, May 13, 2008 00:19:42 +0200: > ... >> I would understand there can be some files that cannot be read. But when >> there is such a file, why is it Ok to ignore an error to update the >> contents from that file if/when the user asks to index the current >> contents, provided if the contents of that file is to be tracked? Isn't >> it the true cause of the problem that the file is being tracked but it >> shouldn't? > > No, I don't think so. Consider "git add dir/". It is _not_ 1 (one) > operation. It is many operations (add every file in the "dir/"). Why > should all of them be considered failed just because the third file > from the bottom could not be read (and the user may have not even seen > it, because it wasn't there before, like a temporary file from Excel). > And for a user (for me, at least) "git add" is an intermediate > operation anyway... Ah, Ok, I was overly cautious, and the worry is unfounded, as long as you do not trigger this "ignore" thing upon "git commit -a". Thanks. Will queue.