git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ping Yin" <pkufranky@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH/RFC 1/7] git-submodule: Extract functions module_info and module_url
Date: Fri, 11 Apr 2008 21:50:54 -0700	[thread overview]
Message-ID: <7vve2nllqp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <46dff0320804112005t9b3cd27gc250dddffb218076@mail.gmail.com> (Ping Yin's message of "Sat, 12 Apr 2008 11:05:23 +0800")

"Ping Yin" <pkufranky@gmail.com> writes:

> On Sat, Apr 12, 2008 at 6:30 AM, Junio C Hamano <junio@pobox.com> wrote:
>> ...
>>  Same comment applies to cmd_update() and cmd_status().  I would strongly
>>  suspect that status may want to ignore missing name/url and show the usual
>>  diff, as it does not even have to require the submodule to interact with
>>  any remote repository at all.  The user may be privately using the
>>  submodule and does not even need to push it out nor pull it from
>>  elsewhere, and in such a case, .gitmodules may not even be populated with
>>  an entry for that submodule, ever, not just as a "right in the middle of
>>  adding" status.
>
> This patch just does refactor, i do this in my sixth patch "Don't die
> when command fails for one submodule"

Fair enough.

As usual, the preferred order is to first refector, fix without
enhancement as necessary, then finally build on more solidified base.

      reply	other threads:[~2008-04-12  4:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10 15:50 [PATCH/RFC] submodule: fallback to .gitmodules and multiple level module definition Ping Yin
2008-04-10 15:50 ` [PATCH/RFC 1/7] git-submodule: Extract functions module_info and module_url Ping Yin
2008-04-10 15:50   ` [PATCH v2 1/3] git-submodule summary: --for-status option Ping Yin
2008-04-10 15:50     ` [PATCH v2 2/3] builtin-status: submodule summary support Ping Yin
2008-04-10 15:50       ` [PATCH/RFC 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone Ping Yin
2008-04-10 15:50         ` [PATCH v2 3/3] buitin-status: Add tests for submodule summary Ping Yin
2008-04-10 15:50           ` [PATCH/RFC 3/7] git-submodule: Fall back on .gitmodules if info not found in $GIT_DIR/config Ping Yin
2008-04-10 15:50             ` [PATCH/RFC 4/7] git-submodule: Extract module_add from cmd_add Ping Yin
2008-04-10 15:50               ` [PATCH/RFC 5/7] git-submodule: multi-level module definition Ping Yin
2008-04-10 15:50                 ` [PATCH/RFC 6/7] git-submodule: Don't die when command fails for one submodule Ping Yin
2008-04-10 15:50                   ` [PATCH/RFC 7/7] git-submodule: "update --force" to enforce cloning non-submodule Ping Yin
2008-04-11 23:24             ` [PATCH/RFC 3/7] git-submodule: Fall back on .gitmodules if info not found in $GIT_DIR/config Junio C Hamano
2008-04-11 23:24             ` Junio C Hamano
2008-04-12  4:26               ` Ping Yin
2008-04-11 21:56         ` [PATCH/RFC 2/7] git-submodule: Extract absolute_url & move absolute url logic to module_clone Junio C Hamano
2008-04-12  2:56           ` Ping Yin
2008-04-10 15:57     ` [PATCH v2 1/3] git-submodule summary: --for-status option Ping Yin
2008-04-11 22:30   ` [PATCH/RFC 1/7] git-submodule: Extract functions module_info and module_url Junio C Hamano
2008-04-12  3:05     ` Ping Yin
2008-04-12  4:50       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vve2nllqp.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pkufranky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).