From: Junio C Hamano <gitster@pobox.com>
To: "Ping Yin" <pkufranky@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/5] git-submodule: New subcommand 'summary' (2) - hard work
Date: Sat, 12 Jan 2008 11:25:05 -0800 [thread overview]
Message-ID: <7vve5ysv72.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <46dff0320801120312i7b22f13vb9fe2394b1f687a9@mail.gmail.com> (Ping Yin's message of "Sat, 12 Jan 2008 19:12:00 +0800")
"Ping Yin" <pkufranky@gmail.com> writes:
>> + echo "* $name $sha1_src...$sha1_dst:"
>
> If it's a type change (head submodule but index blob, or the the
> reverse), $sha1_dst or $sha1_src will be the sha1 of the blob. It's
> inapprociate to be shown as if it's a commit in the submodule. May
> 00000000 should be shown instead of the blob sha1?
I do not think that adds much value. When A or B is a
non-commit, you know that A...B notation does not apply, and
because it is probably a rare situation you would want to make
it even more clearer to the reader by using a different
notation. Like
echo "* $name have changed from submodule $sha1_src to blob $sha1_dst!!".
perhaps in red bold letter in larger font ;-)
next prev parent reply other threads:[~2008-01-12 19:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 7:37 [PATCH 0/5] submodule summary support Ping Yin
2008-01-12 7:37 ` [PATCH 1/5] git-submodule: New subcommand 'summary' (1) - code framework Ping Yin
2008-01-12 7:37 ` [PATCH 2/5] git-submodule: New subcommand 'summary' (2) - hard work Ping Yin
2008-01-12 7:37 ` [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit summary size Ping Yin
2008-01-12 7:37 ` [PATCH 4/5] git-status: submodule summary support Ping Yin
2008-01-12 7:37 ` [PATCH 5/5] git-status: configurable submodule summary size Ping Yin
2008-01-12 8:36 ` [PATCH 3/5] git-submodule: New subcommand 'summary' (3) - limit " Junio C Hamano
2008-01-12 9:51 ` Ping Yin
2008-01-12 19:17 ` Junio C Hamano
2008-01-13 6:38 ` Ping Yin
2008-01-12 8:32 ` [PATCH 2/5] git-submodule: New subcommand 'summary' (2) - hard work Junio C Hamano
2008-01-12 9:48 ` Ping Yin
2008-01-12 12:24 ` Ping Yin
2008-01-12 19:21 ` Junio C Hamano
2008-01-12 11:12 ` Ping Yin
2008-01-12 19:25 ` Junio C Hamano [this message]
2008-01-13 6:28 ` Ping Yin
2008-01-12 8:18 ` [PATCH 1/5] git-submodule: New subcommand 'summary' (1) - code framework Junio C Hamano
2008-01-12 9:09 ` Ping Yin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve5ysv72.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).