git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Stephen Sinclair" <radarsat1@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add committer and author names to top of COMMIT_EDITMSG.
Date: Sat, 12 Jan 2008 00:02:38 -0800	[thread overview]
Message-ID: <7vve5zv5cx.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <9b3e2dc20801112326p2b4eaf96tbd036ed746eff4a3@mail.gmail.com> (Stephen Sinclair's message of "Sat, 12 Jan 2008 02:26:24 -0500")

"Stephen Sinclair" <radarsat1@gmail.com> writes:

>> To rephrase, you would show AUTHOR when one of the conditions
>> holds true, either:
>>
>>  (1) "not me" (so that we can remind that other's commit is
>>      being amended); _OR_
>>
>>  (2) "funny me" (so that we can catch misconfiguration.
>
> I definitely agree with (1), though having not really done much
> amending of other people's commits I can't vouch for it.  I think (2)
> might not be very reliable.

Yeah, I tend to agree that (2) is probably impossible to
achieve.

Author ident should be reachable e-mail address but some people
seem to prefer committer ident to be tied to the actual machine
even if that makes the ident something that merely resembles a
valid reachable e-mail address but in fact unreachable.  For
such a committer ident, taking it from hostname would be a
reasonable thing to do, but I suspect that is a minority.

Unfortunately we do not have an easy way (other than using
GIT_COMMITTER_EMAIL environment) to define different author and
committer idents.

  reply	other threads:[~2008-01-12  8:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-11 20:10 [PATCH] Add committer and author names to top of COMMIT_EDITMSG Stephen Sinclair
2008-01-11 21:26 ` Johannes Schindelin
2008-01-11 23:36 ` Junio C Hamano
2008-01-12  0:09   ` Stephen Sinclair
2008-01-12  0:22     ` Junio C Hamano
2008-01-12  1:33       ` Stephen Sinclair
2008-01-12  1:53         ` Junio C Hamano
2008-01-12  2:25           ` Stephen Sinclair
2008-01-12  4:57             ` Junio C Hamano
2008-01-12  7:26               ` Stephen Sinclair
2008-01-12  8:02                 ` Junio C Hamano [this message]
2008-01-12  4:52           ` Jeff King
2008-01-12  5:06             ` Junio C Hamano
2008-01-12  5:30               ` Junio C Hamano
2008-01-12  5:32                 ` Jeff King
2008-01-12  5:56                   ` Junio C Hamano
2008-01-12  5:58                     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vve5zv5cx.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=radarsat1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).