From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Teach revision walker about reflog ranges
Date: Sat, 29 Dec 2007 16:16:00 -0800 [thread overview]
Message-ID: <7vve6h9gvz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712300000170.14355@wbgn129.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Sun, 30 Dec 2007 00:02:11 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Now you can ask for a revision range
>
> master@{2.weeks.ago..1.day.ago}
>
> or even something like
>
> HEAD@{20..yesterday}
You can _ask_ all you want, but it is not clear what it does
from this description. I guess you are rewriting master@{A..B}
to master@{A}..master@{B}, but that is not clear from the commit
log nor documentation (did I even see a documentation patch?).
Also, I am not convinced that the rewrite gives the semantics
the users naturally expect from @{A..B}. I would even suspect
that people would expect "git log master@{0..2}" to behave more
like "git show master@{0} master@{1} master@{2}".
next prev parent reply other threads:[~2007-12-30 0:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-29 23:02 [PATCH] Teach revision walker about reflog ranges Johannes Schindelin
2007-12-30 0:16 ` Junio C Hamano [this message]
2007-12-30 10:32 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve6h9gvz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).