From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Daniel Berlin <dberlin@dberlin.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
git@vger.kernel.org
Subject: Re: git annotate runs out of memory
Date: Tue, 11 Dec 2007 11:59:29 -0800 [thread overview]
Message-ID: <7vve75c89q.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071211193407.GC20644@artemis.madism.org> (Pierre Habouzit's message of "Tue, 11 Dec 2007 20:34:07 +0100")
Pierre Habouzit <madcoder@debian.org> writes:
>> Looking through thousands of diffs to find the one that happened to
>> your line is also pretty annoying.
>
> If the question you want to answer is "what happened to that line"
> then using git annotate is using a big hammer for no good reason.
>
> git log -S'<put the content of the line here>' -- path/to/file.c
>
> will give you the very same answer, pointing you to the changes that
> added or removed that line directly. It's not a fast command either, but
> it should be less resource hungry than annotate that has to do roughly
> the same for all lines whereas you're interested in one only.
>
> The direct plus here, is that git log output is incremental, so you have
> answers about the first diffs quite quick, which let you examine the
> first answers while the rest is still being computed.
Yes.
> Unlike git annotate, this also allow you to restrict the revisions
> where it searches to a range where you know this happened, which makes
> it almost instantaneous in most cases.
Yes, but blame also takes revision bottoms (obviously you have to start
digging from a single revision so "blame master..next pu" would not
work, but "blame ^foo ^bar baz" would).
> Of course, if the line is ' free(p);\n' then you will probably have
> quite a few false positives,...
You can feed more than a line from -S, and the assumed and recommended
typical use case is to do so.
> Note that it does not justifies the current memory consumption that just
> looks bad and wrong to me,...
Right.
next prev parent reply other threads:[~2007-12-11 20:00 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 17:33 git annotate runs out of memory Daniel Berlin
2007-12-11 17:47 ` Nicolas Pitre
2007-12-11 17:53 ` Daniel Berlin
2007-12-11 18:01 ` Nicolas Pitre
2007-12-11 18:32 ` Marco Costalba
2007-12-11 19:03 ` Daniel Berlin
2007-12-11 19:14 ` Marco Costalba
2007-12-11 19:27 ` Jason Sewall
2007-12-11 19:46 ` Daniel Barkalow
2007-12-11 20:14 ` Marco Costalba
2007-12-11 18:40 ` Linus Torvalds
2007-12-11 19:01 ` Matthieu Moy
2007-12-11 19:22 ` Linus Torvalds
2007-12-11 19:24 ` Daniel Berlin
2007-12-11 19:42 ` Pierre Habouzit
2007-12-11 21:09 ` Daniel Berlin
2007-12-11 23:37 ` Matthieu Moy
2007-12-11 23:48 ` Linus Torvalds
2007-12-11 19:06 ` Nicolas Pitre
2007-12-11 20:31 ` Jon Smirl
2007-12-11 19:09 ` Daniel Berlin
2007-12-11 19:26 ` Daniel Barkalow
2007-12-11 19:34 ` Pierre Habouzit
2007-12-11 19:59 ` Junio C Hamano [this message]
2007-12-11 19:42 ` Linus Torvalds
2007-12-11 19:50 ` Linus Torvalds
2007-12-11 21:14 ` Daniel Berlin
2007-12-11 21:34 ` Linus Torvalds
2007-12-12 7:57 ` Jeff King
2007-12-17 23:24 ` Jan Hudec
2007-12-18 0:05 ` Linus Torvalds
2007-12-11 21:14 ` Linus Torvalds
2007-12-11 21:54 ` Junio C Hamano
2007-12-11 23:36 ` Linus Torvalds
2007-12-12 0:02 ` Linus Torvalds
2007-12-12 0:22 ` Davide Libenzi
2007-12-12 0:50 ` Linus Torvalds
2007-12-12 1:12 ` Davide Libenzi
2007-12-12 2:10 ` Linus Torvalds
2007-12-12 3:35 ` Linus Torvalds
2007-12-12 0:56 ` Junio C Hamano
2007-12-12 2:20 ` Linus Torvalds
2007-12-12 2:39 ` Linus Torvalds
2007-12-12 19:43 ` Daniel Berlin
2007-12-12 4:48 ` Junio C Hamano
2007-12-11 21:24 ` Daniel Berlin
2007-12-12 3:57 ` Shawn O. Pearce
2007-12-11 20:29 ` Marco Costalba
2007-12-11 19:29 ` Steven Grimm
2007-12-11 20:14 ` Jakub Narebski
2007-12-12 10:36 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve75c89q.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dberlin@dberlin.org \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).