From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
Jakub Narebski <jnareb@gmail.com>,
Alex Riesen <raa.lkml@gmail.com>, Andreas Ericsson <ae@op5.se>,
Matthieu Moy <Matthieu.Moy@imag.fr>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 2/3] git-help: add -w|--web option to display html man page in a browser.
Date: Thu, 06 Dec 2007 09:05:33 -0800 [thread overview]
Message-ID: <7vve7bda8y.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071202060755.4d6d5ec8.chriscool@tuxfamily.org> (Christian Couder's message of "Sun, 2 Dec 2007 06:07:55 +0100")
Christian Couder <chriscool@tuxfamily.org> writes:
> diff --git a/help.c b/help.c
> index 0f1cb71..ecc8c66 100644
> --- a/help.c
> +++ b/help.c
> @@ -297,7 +303,14 @@ int cmd_help(int argc, const char **argv, const char *prefix)
> const char *help_cmd = argc > 1 ? argv[1] : NULL;
> check_help_cmd(help_cmd);
>
> - if (!strcmp(help_cmd, "--info") || !strcmp(help_cmd, "-i")) {
> + if (!strcmp(help_cmd, "--web") || !strcmp(help_cmd, "-w")) {
> + help_cmd = argc > 2 ? argv[2] : NULL;
> + check_help_cmd(help_cmd);
> +
> + show_html_page(help_cmd);
> + }
> +
> + else if (!strcmp(help_cmd, "--info") || !strcmp(help_cmd, "-i")) {
> help_cmd = argc > 2 ? argv[2] : NULL;
> check_help_cmd(help_cmd);
Isn't this "check-help-cmd" duplication ugly, by the way?
next prev parent reply other threads:[~2007-12-06 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 5:07 [PATCH 2/3] git-help: add -w|--web option to display html man page in a browser Christian Couder
2007-12-06 17:03 ` Junio C Hamano
2007-12-07 5:35 ` Christian Couder
2007-12-07 6:04 ` Junio C Hamano
2007-12-07 7:05 ` Junio C Hamano
2007-12-08 4:00 ` Christian Couder
2007-12-06 17:05 ` Junio C Hamano [this message]
2007-12-08 8:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve7bda8y.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=ae@op5.se \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=normalperson@yhbt.net \
--cc=raa.lkml@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).