From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Nanako Shiraishi <nanako3@bluebottle.com>,
Shawn Bohrer <shawn.bohrer@gmail.com>,
git@vger.kernel.org
Subject: Re: * [BUG] "git clean" does not pay attention to its parameters
Date: Wed, 05 Dec 2007 02:11:04 -0800 [thread overview]
Message-ID: <7vve7dwix3.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712050947370.27959@racer.site> (Johannes Schindelin's message of "Wed, 5 Dec 2007 09:49:38 +0000 (GMT)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Hi,
>
> On Tue, 4 Dec 2007, Junio C Hamano wrote:
>
>> @@ -85,12 +86,17 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
>> read_directory(&dir, path, base, baselen, pathspec);
>> strbuf_init(&directory, 0);
>>
>> - for (j = 0; j < dir.nr; ++j) {
>> - struct dir_entry *ent = dir.entries[j];
>> - int len, pos, specs;
>> + if (pathspec) {
>> + for (i = 0; pathspec[i]; i++)
>> + ; /* nothing */
>> + seen = xmalloc();
>
> Did you mean xmalloc(i)?
Yes.
next prev parent reply other threads:[~2007-12-05 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 6:54 [BUG] "git clean" does not pay attention to its parameters Nanako Shiraishi
2007-12-05 7:55 ` Junio C Hamano
2007-12-05 9:49 ` Johannes Schindelin
2007-12-05 10:11 ` Junio C Hamano [this message]
2007-12-05 10:50 ` * " Sam Ravnborg
2007-12-05 15:28 ` Shawn Bohrer
2007-12-06 2:14 ` Junio C Hamano
2007-12-05 18:03 ` Jeff King
2007-12-06 3:28 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve7dwix3.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=nanako3@bluebottle.com \
--cc=shawn.bohrer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).