From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: * [BUG] "git clean" does not pay attention to its parameters
Date: Wed, 05 Dec 2007 02:11:04 -0800
Message-ID: <7vve7dwix3.fsf@gitster.siamese.dyndns.org>
References: <200712050654.lB56scKk000311@mi0.bluebottle.com>
	<7veje1zibm.fsf@gitster.siamese.dyndns.org>
	<Pine.LNX.4.64.0712050947370.27959@racer.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Nanako Shiraishi <nanako3@bluebottle.com>,
	Shawn Bohrer <shawn.bohrer@gmail.com>, git@vger.kernel.org
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
X-From: git-owner@vger.kernel.org Wed Dec 05 11:12:06 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IzrEY-0001es-BR
	for gcvg-git-2@gmane.org; Wed, 05 Dec 2007 11:12:02 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751791AbXLEKLN (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Wed, 5 Dec 2007 05:11:13 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751752AbXLEKLN
	(ORCPT <rfc822;git-outgoing>); Wed, 5 Dec 2007 05:11:13 -0500
Received: from sceptre.pobox.com ([207.106.133.20]:59015 "EHLO
	sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751789AbXLEKLM (ORCPT <rfc822;git@vger.kernel.org>);
	Wed, 5 Dec 2007 05:11:12 -0500
Received: from sceptre (localhost.localdomain [127.0.0.1])
	by sceptre.pobox.com (Postfix) with ESMTP id AABEA2F2;
	Wed,  5 Dec 2007 05:11:32 -0500 (EST)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id 2D0FD9C034;
	Wed,  5 Dec 2007 05:11:28 -0500 (EST)
In-Reply-To: <Pine.LNX.4.64.0712050947370.27959@racer.site> (Johannes
	Schindelin's message of "Wed, 5 Dec 2007 09:49:38 +0000 (GMT)")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/67130>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
> On Tue, 4 Dec 2007, Junio C Hamano wrote:
>
>> @@ -85,12 +86,17 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
>>  	read_directory(&dir, path, base, baselen, pathspec);
>>  	strbuf_init(&directory, 0);
>>  
>> -	for (j = 0; j < dir.nr; ++j) {
>> -		struct dir_entry *ent = dir.entries[j];
>> -		int len, pos, specs;
>> +	if (pathspec) {
>> +		for (i = 0; pathspec[i]; i++)
>> +			; /* nothing */
>> +		seen = xmalloc();
>
> Did you mean xmalloc(i)?

Yes.