* [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test
@ 2007-11-01 13:23 Jakub Narebski
2007-11-01 22:18 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Narebski @ 2007-11-01 13:23 UTC (permalink / raw)
To: git; +Cc: Jakub Narebski
It does appear to do nothing; gitweb is run as standalone program
and not as CGI script in this test. This call caused problems later.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
t/t9500-gitweb-standalone-no-errors.sh | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
index f7bad5b..1bf0988 100755
--- a/t/t9500-gitweb-standalone-no-errors.sh
+++ b/t/t9500-gitweb-standalone-no-errors.sh
@@ -31,7 +31,6 @@ our \$projects_list = "";
our \$export_ok = "";
our \$strict_export = "";
-CGI::Carp::set_programname("gitweb/gitweb.cgi");
EOF
cat >.git/description <<EOF
--
1.5.3.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test
2007-11-01 13:23 [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test Jakub Narebski
@ 2007-11-01 22:18 ` Junio C Hamano
2007-11-01 23:36 ` Jakub Narebski
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2007-11-01 22:18 UTC (permalink / raw)
To: Jakub Narebski; +Cc: git
Jakub Narebski <jnareb@gmail.com> writes:
> It does appear to do nothing; gitweb is run as standalone program
> and not as CGI script in this test. This call caused problems later.
Care to describe "later problems" a bit more?
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> t/t9500-gitweb-standalone-no-errors.sh | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
> index f7bad5b..1bf0988 100755
> --- a/t/t9500-gitweb-standalone-no-errors.sh
> +++ b/t/t9500-gitweb-standalone-no-errors.sh
> @@ -31,7 +31,6 @@ our \$projects_list = "";
> our \$export_ok = "";
> our \$strict_export = "";
>
> -CGI::Carp::set_programname("gitweb/gitweb.cgi");
> EOF
>
> cat >.git/description <<EOF
> --
> 1.5.3.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test
2007-11-01 22:18 ` Junio C Hamano
@ 2007-11-01 23:36 ` Jakub Narebski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Narebski @ 2007-11-01 23:36 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
>> It does appear to do nothing; gitweb is run as standalone program
>> and not as CGI script in this test. This call caused problems later.
>
> Care to describe "later problems" a bit more?
Sorry about that. The problems were while creating yet-to-be send
patch
"gitweb: Add tests for overriding gitweb config with repo config"
Perhaps not in the current version. I forgot details.
Perhaps last sentence "This call caused problems later." should be
simply removed from commit message.
--
Jakub Narebski
Poland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-01 23:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-01 13:23 [PATCH] gitweb: Remove CGI::Carp::set_programname() call from t9500 gitweb test Jakub Narebski
2007-11-01 22:18 ` Junio C Hamano
2007-11-01 23:36 ` Jakub Narebski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).