From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pierre Habouzit <madcoder@debian.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Fix revision log diff setup, avoid unnecessary diff generation
Date: Sat, 29 Sep 2007 15:11:31 -0700 [thread overview]
Message-ID: <7vve9tjf58.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0709290932040.3579@woody.linux-foundation.org> (Linus Torvalds's message of "Sat, 29 Sep 2007 09:50:39 -0700 (PDT)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Sat, 29 Sep 2007, Pierre Habouzit wrote:
>>
>> - if (strcmp(argv[i], "-z"))
>> - revs->diff = 1;
>> + revs->diff = strcmp(argv[i], "-z")
>> + && strcmp(argv[i], "--color")
>> + && strcmp(argv[i], "--no-color");
>
> The old code was already pretty damn ugly, the new code is worse (never
> mind the bug).
>
> I don't think we should care *at*all* about the actual argument string, we
> should just look at what the diffopts end up being at the end.
Thanks, I think this is the sanest thing to do.
next prev parent reply other threads:[~2007-09-29 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 10:02 Big performance regression with --no-color option in git-log Marco Costalba
2007-09-29 11:01 ` Pierre Habouzit
2007-09-29 11:09 ` Pierre Habouzit
2007-09-29 11:29 ` Marco Costalba
2007-09-29 12:35 ` [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed Pierre Habouzit
2007-09-29 12:52 ` David Kastrup
2007-09-29 12:56 ` Pierre Habouzit
2007-09-29 13:06 ` Marco Costalba
2007-09-29 13:07 ` Marco Costalba
2007-09-29 16:50 ` Fix revision log diff setup, avoid unnecessary diff generation Linus Torvalds
2007-09-29 22:11 ` Junio C Hamano [this message]
2007-09-29 17:02 ` [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve9tjf58.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).