From: Junio C Hamano <gitster@pobox.com>
To: "Josh England" <jjengla@sandia.gov>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] post-checkout hooks and related tests
Date: Tue, 25 Sep 2007 16:17:46 -0700 [thread overview]
Message-ID: <7vve9y2v39.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1190760563-32453-1-git-send-email-jjengla@sandia.gov> (Josh England's message of "Tue, 25 Sep 2007 16:49:21 -0600")
"Josh England" <jjengla@sandia.gov> writes:
> diff --git a/git-checkout.sh b/git-checkout.sh
> index 17f4392..78355eb 100755
> --- a/git-checkout.sh
> +++ b/git-checkout.sh
> @@ -137,6 +137,13 @@ Did you intend to checkout '$@' which can not be resolved as commit?"
> git ls-files --error-unmatch -- "$@" >/dev/null || exit
> git ls-files -- "$@" |
> git checkout-index -f -u --stdin
> +
> + # Run a post-checkout hook -- the HEAD does not change so the
> + # current HEAD is passed in for both args
> + if test -x "$GIT_DIR"/hooks/post-checkout; then
It is usually a good idea to view your patch in your MUA before
sending them out.
You will spot HT vs SP indentation inconsistencies right away.
HEAD did not change but don't you want to differenciate if the
checkout was from the index or from the HEAD? If not why not?
next prev parent reply other threads:[~2007-09-25 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 22:49 [PATCH] post-checkout hooks and related tests Josh England
2007-09-25 22:49 ` [PATCH] post-merge hook " Josh England
2007-09-25 22:49 ` [PATCH] Documentation for post-checkout and post-merge hooks Josh England
2007-09-25 23:21 ` [PATCH] post-merge hook and related tests Junio C Hamano
2007-09-25 23:17 ` Junio C Hamano [this message]
2007-09-26 17:16 ` [PATCH] post-checkout hooks " Josh England
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve9y2v39.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jjengla@sandia.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).