From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] diff: squelch empty diffs even more
Date: Tue, 14 Aug 2007 16:52:15 -0700 [thread overview]
Message-ID: <7vvebhad3k.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <46C22F7C.1000502@lsrfire.ath.cx> (René Scharfe's message of "Wed, 15 Aug 2007 00:41:00 +0200")
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> Hmm. Like this?
>
> The patch adds a new diff_options bitfield member, no_index, that
> is used instead of the special value of -2 of the rev_info field
> max_count to indicate that the index is not to be used. This makes
> it possible to pass that flag down to diffcore_skip_stat_unmatch(),
> which only has one diff_options parameter.
>
> This could even become a cleanup if we removed all assignments of
> max_count to a value of -2 (viz. replacement of a magic value with
> a self-documenting field name) but I didn't dare to do that so late
> in the rc game..
>
> The no_index bit, if set, then tells diffcore_skip_stat_unmatch()
> to not account for any skipped stat-mismatches, which avoids the
> suggestion to run git-status.
Yeah, I've always hated that -2 magic hack, and I think this is
the right way to go. Dscho?
next prev parent reply other threads:[~2007-08-14 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 21:09 [PATCH] diff: squelch empty diffs even more René Scharfe
2007-08-14 21:29 ` Junio C Hamano
2007-08-14 22:41 ` René Scharfe
2007-08-14 23:52 ` Junio C Hamano [this message]
2007-08-15 14:47 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvebhad3k.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox