From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] checkout-index needs a working tree
Date: Sat, 04 Aug 2007 15:50:11 -0700 [thread overview]
Message-ID: <7vvebuj4nw.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0708042319470.14781@racer.site> (Johannes Schindelin's message of "Sat, 4 Aug 2007 23:20:07 +0100 (BST)")
Hmmph. I was trying to come up with a better commit log message
for this change.
Paths given from the command line of checkout-index name
files relative to the cwd, whose implication is that it
is relative to where you are in relation with the top of
the working tree. For doing that, you need to have the
work tree to begin with.
Does this mean that any command that uses its prefix parameter
to cmd_xxx() needs NEED_WORK_TREE?
I wonder if it would help us to catch similar breakages if we
change git.c::run_command() so that we do not pass prefix (or
pass a bogus pointer ((const char *)1)) for commands that do not
ask for NEED_WORK_TREE.
next prev parent reply other threads:[~2007-08-04 22:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 22:20 [PATCH] checkout-index needs a working tree Johannes Schindelin
2007-08-04 22:50 ` Junio C Hamano [this message]
2007-08-05 1:33 ` Johannes Schindelin
2007-08-09 22:35 ` Uwe Kleine-König
2007-08-10 0:31 ` Johannes Schindelin
2007-08-10 0:55 ` Junio C Hamano
2007-08-10 1:11 ` Johannes Schindelin
2007-08-10 7:57 ` [PATCH] Reinstate the old behaviour when GIT_DIR is set and GIT_WORK_TREE is unset Junio C Hamano
2007-08-10 11:28 ` Uwe Kleine-König
2007-08-10 19:26 ` Junio C Hamano
2007-08-11 5:17 ` Junio C Hamano
2007-08-11 18:15 ` [PATCH] checkout-index doc: use --work-dir in the export example Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvebuj4nw.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).