Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Julian Phillips <julian@quantumfyre.co.uk>
Cc: Ron Parker <ron.parker@mobot.org>, git@vger.kernel.org
Subject: Re: [PATCH] Fix tests when using bash_completion
Date: Mon, 23 Apr 2007 14:56:27 -0700	[thread overview]
Message-ID: <7vvefmdab8.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0704232235280.7626@beast.quantumfyre.co.uk> (Julian Phillips's message of "Mon, 23 Apr 2007 22:39:20 +0100 (BST)")

Julian Phillips <julian@quantumfyre.co.uk> writes:

> (I'm not the only one who thinks CDPATH is ick am I? :S)

CDPATH is Ok as long as it stays as an interactive shell
variable.

Sadly, if you google for "CDPATH environment", you would see
many many hits.  That variable is not meant to be used as an
environment variable.

Something like this in .bashrc is acceptable:

	case "$PS1" in
        '')
        	;; # do not do useless thing for noninteractive
	?*)
        	CDPATH=my:favorite:path
                . $HOME/.bash-completion
		;;
	esac

but people usually are way too careless than that and export
CDPATH to the environment, and that is where breakages start.

  reply	other threads:[~2007-04-23 21:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-23 20:51 [PATCH] Fix tests when using bash_completion Ron Parker
2007-04-23 21:15 ` Junio C Hamano
2007-04-23 21:39   ` Julian Phillips
2007-04-23 21:56     ` Junio C Hamano [this message]
2007-04-23 22:57       ` [OT] CDPATH (was: Re: [PATCH] Fix tests when using bash_completion) Julian Phillips
2007-04-24 13:34         ` [OT] CDPATH Ron Parker
2007-04-24 16:57           ` Junio C Hamano
2007-04-24 19:01             ` [PATCH] Unset CDPATH in the test library Ron Parker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvefmdab8.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=julian@quantumfyre.co.uk \
    --cc=ron.parker@mobot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox