From: Junio C Hamano <junkio@cox.net>
To: Jon Loeliger <jdl@jdl.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Removed memory leaks from interpolation table uses.
Date: Wed, 27 Sep 2006 12:42:52 -0700 [thread overview]
Message-ID: <7vven99jur.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <E1GSc4w-0005cu-I3@jdl.com> (Jon Loeliger's message of "Wed, 27 Sep 2006 11:16:10 -0500")
Jon Loeliger <jdl@jdl.com> writes:
> Junio,
>
> This is on top of my previous cleanup [PATCH Rev 3].
Thanks.
> BTW, In that previous patch of mine, this line:
>
> - and %D for the absolute path of the named repository.
>
> has trailing blanks in my patch that must be removed in order
> to apply it correctly to the HEAD of git. The _previous_ patch
> clearly was (correctly) applied with --whitepace=strip!
Yes, I usually use --whitespace=strip. The only time I
deliberately had to turn it off was to apply patches to diff
output test vectors.
Hopefully the recent addition to "diff --color" output to highlight
these potential whitespace errors would help spot them before
making commits.
prev parent reply other threads:[~2006-09-27 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-27 16:16 [PATCH] Removed memory leaks from interpolation table uses Jon Loeliger
2006-09-27 19:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vven99jur.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jdl@jdl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).