From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] fmt-merge-msg: avoid open "-|" list form for Perl 5.6
Date: Thu, 02 Mar 2006 17:25:59 -0800
Message-ID: <7vveuw48uw.fsf@assigned-by-dhcp.cox.net>
References: <20060302164405.GB7292@trixie.casa.cgf.cx>
	<20060302165510.GB18929@spearce.org>
	<20060302220930.GE6183@steel.home>
	<Pine.LNX.4.64.0603021521250.22647@g5.osdl.org>
	<7v1wxk5ptf.fsf@assigned-by-dhcp.cox.net>
	<Pine.LNX.4.64.0603021643560.22647@g5.osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org
X-From: git-owner@vger.kernel.org Fri Mar 03 02:26:08 2006
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1FEz3W-0005k4-BT
	for gcvg-git@gmane.org; Fri, 03 Mar 2006 02:26:08 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752119AbWCCB0B (ORCPT <rfc822;gcvg-git@m.gmane.org>);
	Thu, 2 Mar 2006 20:26:01 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752120AbWCCB0B
	(ORCPT <rfc822;git-outgoing>); Thu, 2 Mar 2006 20:26:01 -0500
Received: from fed1rmmtao01.cox.net ([68.230.241.38]:26770 "EHLO
	fed1rmmtao01.cox.net") by vger.kernel.org with ESMTP
	id S1752119AbWCCB0B (ORCPT <rfc822;git@vger.kernel.org>);
	Thu, 2 Mar 2006 20:26:01 -0500
Received: from assigned-by-dhcp.cox.net ([68.4.9.127])
          by fed1rmmtao01.cox.net
          (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP
          id <20060303012442.ZIKA15695.fed1rmmtao01.cox.net@assigned-by-dhcp.cox.net>;
          Thu, 2 Mar 2006 20:24:42 -0500
To: Linus Torvalds <torvalds@osdl.org>
In-Reply-To: <Pine.LNX.4.64.0603021643560.22647@g5.osdl.org> (Linus Torvalds's
	message of "Thu, 2 Mar 2006 16:49:26 -0800 (PST)")
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/17133>

Linus Torvalds <torvalds@osdl.org> writes:

> Yeah, I actually looked at a few examples, so I knew what it was basically 
> trying to do, and then I ignored it as not interesting to the exercise, 
> which was to abuse the new revision listing library in interesting ways by 
> calling it multiple times.

Abuse is exactly the word.  The reason it is an abuse is exactly
why you said "... but to fix it you'd have to actualyl walk the
parent list yourself, rather than letting get_revision do it all
for you."  Which relates to the fact that object.c layer is not
designed to be used multiple times...

Maybe we want to make object.c layer reusable first?