From: Junio C Hamano <junkio@cox.net>
To: Martin Mares <mj@ucw.cz>
Cc: git@vger.kernel.org
Subject: Re: git-cvs-import retries
Date: Sat, 18 Feb 2006 10:42:44 -0800 [thread overview]
Message-ID: <7vvevco6e3.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <mj+md-20060218.130645.5680.albireo@ucw.cz> (Martin Mares's message of "Sat, 18 Feb 2006 14:14:07 +0100")
Martin Mares <mj@ucw.cz> writes:
> But it did and I finally understand why: _line() can exit not only
> by return, but also by falling over when readline() returns undef.
Ah, you are right and I feel stupid. It's been a while since I
wrote real Perl code the last time, and forgot that "the last
evaluation" rule when I was reading the code.
It did not help that one of the languages I use in my day-job
(which I am too ashamed to even name) uses "if fell off at the
end return undef" rule X-<.
next prev parent reply other threads:[~2006-02-18 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 19:38 git-cvs-import retries Martin Mares
2006-02-18 7:27 ` Junio C Hamano
2006-02-18 13:14 ` Martin Mares
2006-02-18 18:42 ` Junio C Hamano [this message]
2006-02-18 20:44 ` [PATCH] Fix retries in git-cvsimport Martin Mares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvevco6e3.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).