From: Junio C Hamano <junkio@cox.net>
To: Greg KH <greg@kroah.com>
Cc: git@vger.kernel.org
Subject: Re: diffstat wierdness with 'git format-patch' output
Date: Mon, 13 Feb 2006 22:09:30 -0800 [thread overview]
Message-ID: <7vveviv5d1.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060214055648.GA592@kroah.com> (Greg KH's message of "Mon, 13 Feb 2006 21:56:48 -0800")
Greg KH <greg@kroah.com> writes:
> Hm, in looking at it closer, it's probably the last two lines of the
> file, the signature that git format-patch adds to the message:
> --
> 1.2.0
If that is the case, it's unfortunate that diffstat is broken
and is not properly counting lines to tell which lines are part
of the patch and which lines are not.
Have you tried "git apply --stat" instead?
> Any way to suppress these?
Sorry, there is no option to disable that, but the stuff is
GPLv2 so you can do whatever ;-).
The string "-- \n" is an established convention to mark the
beginning of the signature (or whatever inmaterial stuff that
follow the message contents), so changing the marker is
pointless -- if we want the option it should be to delete those
two lines altogether.
I personally find it useful to see the trend of version of tools
people use on the public mailing list, and that was the primary
reason it is there.
Have you tried "git apply --stat --summary" instead?
next prev parent reply other threads:[~2006-02-14 6:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 5:54 diffstat wierdness with 'git format-patch' output Greg KH
2006-02-14 5:56 ` Greg KH
2006-02-14 6:09 ` Junio C Hamano [this message]
2006-02-14 6:34 ` Greg KH
2006-02-14 6:37 ` Junio C Hamano
2006-02-14 6:44 ` Greg KH
2006-02-14 6:42 ` Greg KH
2006-02-14 6:52 ` Greg KH
2006-02-14 7:10 ` Junio C Hamano
2006-02-18 0:34 ` Greg KH
2006-02-14 22:30 ` Fredrik Kuivinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vveviv5d1.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=greg@kroah.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).