From: Junio C Hamano <junkio@cox.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] use "git init-db" in tests
Date: Fri, 09 Dec 2005 00:52:27 -0800 [thread overview]
Message-ID: <7vvexy4ppw.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vlkyu7l05.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Fri, 09 Dec 2005 00:06:02 -0800")
Junio C Hamano <junkio@cox.net> writes:
> Linkage error of git-init-db (or git wrapper) may leave the file
> created but leave that in unexecutable form, which could be a
> valid concern, but that would signal an error to the make during
> the build stage, and "test" target depends on "all" target.
BTW, I sometimes wished if it were easier to disable that "test:
all" dependency and run tests without building things first,
i.e. deliberately using the already installed binaries, so that
I can make sure that updated or new tests reproduce and catch
problems with the existing code first and then make sure the
binaries built from the updated sources fix the problem.
Of course that is a very specialized application so a makefile
variable "make NO_BUILD_BEFORE_TEST=YesPlease test" would not
make much sense, but I could have done something like this:
---
diff --git a/Makefile b/Makefile
index 01b6643..8dd7be7 100644
--- a/Makefile
+++ b/Makefile
@@ -439,7 +439,13 @@ doc:
### Testing rules
-test: all
+ifdef NO_BUILD_BEFORE_TEST
+test_depends =
+else
+test_depends = all
+endif
+
+test: $(test_depends)
$(MAKE) -C t/ all
test-date$X: test-date.c date.o ctype.o
next prev parent reply other threads:[~2005-12-09 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 20:25 [PATCH] use "git init-db" in tests Alex Riesen
2005-12-08 20:47 ` Junio C Hamano
2005-12-08 21:02 ` Alex Riesen
2005-12-08 21:24 ` Junio C Hamano
2005-12-09 7:36 ` Alex Riesen
2005-12-09 8:06 ` Junio C Hamano
2005-12-09 8:52 ` Junio C Hamano [this message]
2005-12-09 9:30 ` Petr Baudis
2005-12-09 10:59 ` Alex Riesen
2005-12-09 20:46 ` Junio C Hamano
2005-12-08 20:59 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvexy4ppw.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).