From: Junio C Hamano <junkio@cox.net>
To: Nick Hengeveld <nickh@reactrix.com>
Cc: Petr Baudis <pasky@suse.cz>, git@vger.kernel.org
Subject: Re: [PATCH] Show URL in the "Getting <foo> list" http-fetch messages
Date: Mon, 14 Nov 2005 12:11:46 -0800 [thread overview]
Message-ID: <7vveyvxa4d.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20051114190225.GA3793@reactrix.com> (Nick Hengeveld's message of "Mon, 14 Nov 2005 11:02:26 -0800")
Nick Hengeveld <nickh@reactrix.com> writes:
> On Sat, Nov 12, 2005 at 09:22:02AM -0800, Nick Hengeveld wrote:
>
>> This should not be an issue with index requests because they are only
>> initiated from fetch(). The previous patch to load alternates on demand
>> added alternate handling to process_curl_messages() so that a 404 for an
>> object can be handled immediately rather than waiting for the fetch()
>> call for that object to notice.
>
> Seems like it might make sense to handle pack downloads immediately when
> an object is unavailable rather than waiting for the fetch() call. It
> could prevent attempts to download any other objects inside that pack,
> although queued requests that activate while a pack is downloading
> would have to wait to see whether the download is successful.
I think that makes sense, and it probably is preferable to make
them wait than blindly go ahead. Although we are issuing
requests in parallel, these simultaneous requests are asking for
related things (e.g. parent commit objects or the tree object of
the commit we just saw; blob objects contained in the tree we
just saw) and are more likely than not to be found in the pack
being requested. Losing parallelism while a pack is in transit
would not be too much of a problem.
prev parent reply other threads:[~2005-11-14 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-12 0:49 [PATCH] Show URL in the "Getting <foo> list" http-fetch messages Petr Baudis
2005-11-12 0:58 ` Petr Baudis
2005-11-12 1:17 ` Junio C Hamano
2005-11-12 17:22 ` Nick Hengeveld
2005-11-14 19:02 ` Nick Hengeveld
2005-11-14 20:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vveyvxa4d.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=nickh@reactrix.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).