From: Junio C Hamano <junkio@cox.net>
To: Raja R Harinath <rharinath@novell.com>, exon@op5.se (Andreas Ericsson)
Cc: git@vger.kernel.org
Subject: Re: [PATCH] C implementation of the 'git' program.
Date: Thu, 10 Nov 2005 23:40:07 -0800 [thread overview]
Message-ID: <7vveyzskdk.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <m3lkzv4qnz.fsf@harinath.blr.novell.com> (Raja R. Harinath's message of "Fri, 11 Nov 2005 12:28:08 +0530")
Raja R Harinath <rharinath@novell.com> writes:
> This is bad, since it does the wrong thing for the correct way:
>
> make prefix=/usr
> sudo make prefix=/usr install
>
> With your patch 'git' will be compiled as root.
You are correct.
We should allow building as user and installing as root, with
the installation step _not_ touching the build directory at all.
A good litmus test is that you should be able to build and
install from a root-squashed NFS mounted working tree, without
giving write permissions to NFS-nobody user (obviously you need
to give read and search permissions).
Andreas?
next prev parent reply other threads:[~2005-11-11 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-10 18:26 [PATCH] C implementation of the 'git' program Andreas Ericsson
2005-11-10 19:41 ` Linus Torvalds
2005-11-10 22:50 ` Andreas Ericsson
2005-11-10 23:37 ` Petr Baudis
2005-11-11 19:31 ` Junio C Hamano
2005-11-11 6:58 ` Raja R Harinath
2005-11-11 7:40 ` Junio C Hamano [this message]
2005-11-11 12:04 ` Andreas Ericsson
2005-11-11 19:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vveyzskdk.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=exon@op5.se \
--cc=git@vger.kernel.org \
--cc=rharinath@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).