From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: Still unsafe: write_sha1_from_fd()
Date: Thu, 06 Oct 2005 15:37:40 -0700 [thread overview]
Message-ID: <7vvf0a5l1n.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0510061520400.31407@g5.osdl.org> (Linus Torvalds's message of "Thu, 6 Oct 2005 15:26:52 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
> The only user is apparently ssh-fetch, but especially since the input-fd
> is a network connection, it looks like it is not at all unlikely that this
> case will trigger - all it takes is somebody impatient waiting for a large
> object.
>
> Ugh,
Ugh indeed.
I'd vote for renaming it to a less generic name, moving it out
of sha1_file.c -- make it static in ssh-fetch.c -- and slowly
deprecate the use of ssh-fetch/ssh-upload pair.
I do not see much point prefering it over the pack transfer
protocol anyway, if you already have ssh access to the box.
prev parent reply other threads:[~2005-10-06 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-06 22:26 Still unsafe: write_sha1_from_fd() Linus Torvalds
2005-10-06 22:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvf0a5l1n.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox