From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: [PATCH] typo fixes to git-apply-patch-script
Date: Sun, 01 May 2005 20:19:41 -0700 [thread overview]
Message-ID: <7vvf62pb5e.fsf@assigned-by-dhcp.cox.net> (raw)
When git-apply-patch-script creates a new file without
executable mode set, a typo caused it not to report that
activity to the user. Also it was mistakenly running
git-update-cache twice for newly created or deleted paths. This
patch fixes these problems.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
****************************************************************
Linus, please do not forget to make this script EXECUTABLE this
time.
****************************************************************
jit-diff linus-mirror: git-apply-patch-script
# - Fix missing '\n' at end of git-cat-file -t output.
# + working-tree
Mode changed: git-apply-patch-script (100644->100755)
--- k/git-apply-patch-script
+++ l/git-apply-patch-script
@@ -31,7 +31,7 @@ test -f "$name.rej" || {
echo >&2 "created $name with mode +x."
chmod "$mode2" "$name"
;;
- -)
+ -x)
echo >&2 "created $name."
;;
esac
@@ -52,9 +52,7 @@ test -f "$name.rej" || {
chmod "$mode2" "$name"
;;
esac
+ git-update-cache -- "$name"
esac
- # This bit is debatable---the SCM may not want to keep
- # cache in sync with the work tree (JIT does want to).
- git-update-cache -- "$name"
}
exit 0
reply other threads:[~2005-05-02 3:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvf62pb5e.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox