From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2012, #05; Tue, 18)
Date: Thu, 20 Dec 2012 10:13:37 -0800 [thread overview]
Message-ID: <7vwqwc617y.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121220145941.GC27211@sigill.intra.peff.net> (Jeff King's message of "Thu, 20 Dec 2012 09:59:41 -0500")
Jeff King <peff@peff.net> writes:
> On Tue, Dec 18, 2012 at 12:31:43PM -0800, Junio C Hamano wrote:
>
>> * jk/error-const-return (2012-12-15) 2 commits
>> - silence some -Wuninitialized false positives
>> - make error()'s constant return value more visible
>>
>> Help compilers' flow analysis by making it more explicit that
>> error() always returns -1, to reduce false "variable used
>> uninitialized" warnings.
>>
>> This is still an RFC.
>
> What's your opinion on this?
Ugly but not too much so, and it would be useful.
The only thing that makes it ugly is that it promises error() will
return -1 and nothing else forever, but at this point in the
evolution of the codebase, I think we are pretty much committed to
it anyway, so I do not think it is a problem.
next prev parent reply other threads:[~2012-12-20 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 20:31 What's cooking in git.git (Dec 2012, #05; Tue, 18) Junio C Hamano
2012-12-19 20:47 ` Junio C Hamano
2012-12-20 14:59 ` Jeff King
2012-12-20 18:13 ` Junio C Hamano [this message]
2012-12-20 19:58 ` Jeff King
2012-12-20 20:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwqwc617y.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).