From: Junio C Hamano <gitster@pobox.com>
To: Ben Walton <bwalton@artsci.utoronto.ca>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] configure: Allow GIT_ARG_SET_PATH to handle --without-PROGRAM
Date: Mon, 01 Feb 2010 13:14:40 -0800 [thread overview]
Message-ID: <7vwrywu08v.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1264990505-29578-2-git-send-email-bwalton@artsci.utoronto.ca> (Ben Walton's message of "Sun\, 31 Jan 2010 21\:15\:04 -0500")
Ben Walton <bwalton@artsci.utoronto.ca> writes:
> Add an optional second argument to both GIT_ARG_SET_PATH and
> GIT_CONF_APPEND_PATH such that any value of the second argument will
> enable configure to set NO_$PROGRAM in addition to an empty
> $PROGRAM_PATH. This is initially useful for allowing configure to
> disable the use of python, as the remote helper code has nothing
> leveraging it yet.
>
> The Makefile already recognizes NO_PYTHON, but configure provided no
> way to set it appropriately.
>
> Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
> ---
Interesting.
I noticed that even without this patch we seem to honor --without-tcltk
just fine and wondered why. It turns out that we already do the right
thing when TCLTK_PATH is empty to set NO_TCLTK in our Makefile, but we at
the same time have a long custom code in configure.ac to support tcltk.
Perhaps we can clean-up with-/without-tcltk part in configure.ac using
this?
next prev parent reply other threads:[~2010-02-01 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 2:15 [PATCH 0/2] configure tweaks for NO_PYTHON Ben Walton
2010-02-01 2:15 ` [PATCH 1/2] configure: Allow GIT_ARG_SET_PATH to handle --without-PROGRAM Ben Walton
2010-02-01 2:15 ` [PATCH 2/2] configure: Allow --without-python Ben Walton
2010-02-01 21:14 ` Junio C Hamano [this message]
2010-02-01 21:23 ` [PATCH 1/2] configure: Allow GIT_ARG_SET_PATH to handle --without-PROGRAM Ben Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwrywu08v.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox