From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: John Dlugosz <JDlugosz@TradeStation.com>, git@vger.kernel.org
Subject: Re: Cryptic error messages?
Date: Wed, 22 Apr 2009 14:14:00 -0700 [thread overview]
Message-ID: <7vws9c1jdz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090422205006.GE14146@coredump.intra.peff.net> (Jeff King's message of "Wed, 22 Apr 2009 16:50:07 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Apr 22, 2009 at 04:32:51PM -0400, Jeff King wrote:
>
>> 3. receive-pack notices that the unpacker failed, and spews
>>
>> error: unpack failed: unpacker exited with error code
>>
>> to stderr, in case unpack-objects didn't say anything.
>
> Actually, this is not true. receive-pack actually passes the error code
> back to send-pack, which prints it. I think it is doing so because we
> get that status separate from the individual ref status. But if you look
> at receive-pack, it doesn't even bother trying individual refs if the
> unpack failed; every ref will just get the "unpack failed" message.
How could it even "bother" to tell which ref? The protocol says "Here are
the values for the refs after you unpack the data that follows; here is
the pack data for you", and then you find the error in the pack data.
next prev parent reply other threads:[~2009-04-22 21:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 20:18 Cryptic error messages? John Dlugosz
2009-04-21 12:08 ` Dmitry Potapov
2009-04-21 16:54 ` John Dlugosz
2009-04-22 20:32 ` Jeff King
2009-04-22 20:50 ` Jeff King
2009-04-22 21:14 ` Junio C Hamano [this message]
2009-04-22 21:23 ` Jeff King
2009-04-22 22:07 ` John Dlugosz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vws9c1jdz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=JDlugosz@TradeStation.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox