From: Junio C Hamano <gitster@pobox.com>
To: Erik Faye-Lund <kusmabite@googlemail.com>
Cc: Erik Faye-Lund <kusmabite@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/4] test-suite: adding a test for fast-export with tag variants
Date: Sun, 29 Mar 2009 14:32:11 -0700 [thread overview]
Message-ID: <7vwsa8ow10.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <40aa078e0903291305p28ec2ae8xf0cb465e593af0b0@mail.gmail.com> (Erik Faye-Lund's message of "Sun, 29 Mar 2009 22:05:36 +0200")
Erik Faye-Lund <kusmabite@googlemail.com> writes:
> OK, I see now that the previous patch-series has been merged to "pu".
> Is there a reason why this updated patch-series hasn't superseded it?
Even if the tested program crashes, it is Ok to test them inside
expect_failure, so I'd suggest not commenting the first two out.
But running the tests with the first patch applied to the same base as
where v1 was applied gives this, which is a more serious issue:
$ sh t9301-fast-export.sh 2>&1 | tail -n 2
* still have 4 known breakage(s)
* failed 6 among remaining 15 test(s)
In other words, the changes to the set-up part seem to break unrelated
tests. Why can such an update supersede the previous one?
next prev parent reply other threads:[~2009-03-29 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 12:53 [PATCH 1/4] test-suite: adding a test for fast-export with tag variants Erik Faye-Lund
2009-03-23 12:53 ` [PATCH 2/4] builtin-fast-export.c: turn error into warning Erik Faye-Lund
2009-03-23 12:53 ` [PATCH 3/4] builtin-fast-export.c: fix crash on tagged trees Erik Faye-Lund
2009-03-23 12:53 ` [PATCH 4/4] builtin-fast-export.c: handle nested tags Erik Faye-Lund
2009-03-29 20:05 ` [PATCH 1/4] test-suite: adding a test for fast-export with tag variants Erik Faye-Lund
2009-03-29 21:32 ` Junio C Hamano [this message]
2009-03-29 21:44 ` Erik Faye-Lund
2009-03-30 2:50 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2009-03-30 9:08 Erik Faye-Lund
2009-03-22 21:50 Erik Faye-Lund
2009-03-23 0:39 ` Junio C Hamano
2009-03-23 0:55 ` Erik Faye-Lund
2009-03-23 3:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwsa8ow10.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=kusmabite@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).