git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Tuncer Ayaz <tuncer.ayaz@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH] shortstatus v1
Date: Tue, 10 Feb 2009 07:58:47 -0800	[thread overview]
Message-ID: <7vwsbynv0o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090210110330.GB12089@coredump.intra.peff.net

Jeff King <peff@peff.net> writes:

> Some comments:
>
>   1. Is the staggered indentation intentional? It looks awful, and the
>      only use I can think of is to separate unstaged from staged
>      changes. But surely there must be a more obvious way of doing so.

Probably not.

>   2. Why do staged changes get a letter marking what happened, but
>      unstaged changes do not?

Bug?   FWIW, the original patch from October shows:

    M changed
M   M changed-again
M     changed-staged
    D deleted
D     deleted-staged

(where changed-again has both staged changes and further changes in the
work tree).

The gap between these two are to show the rename similarity index, which
we could do without.

>   3. What advantage does this have over just doing:
>
>        (git diff --name-status;
>         git diff --cached --name-status) | sort -k2
>
>> Right now this is basically Junio's shortstatus
>> from Oct 25th 2008 with no substantial change
>> except a line or two.
>
> This is not a very helpful commit message. What is it supposed to do?
> What does the output look like? Why is it implemented this way? If Junio
> sent a patch in October and it isn't substantially changed, why wasn't
> it accepted then?

The output mimicked what was in Shawn's "repo" tool announcement IIRC.

My patch was supposed to give interested parties hint to base a patch like
Tuncer's on (I think this answers your last question, too).

  parent reply	other threads:[~2009-02-10 16:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10  0:51 [RFC/PATCH] shortstatus v1 Tuncer Ayaz
2009-02-10  1:44 ` Junio C Hamano
2009-02-10  3:46   ` Sitaram Chamarty
2009-02-10 10:22     ` Spending time in PS1, was " Johannes Schindelin
2009-02-10 17:31       ` Sitaram Chamarty
2009-02-10 10:11   ` Tuncer Ayaz
2009-02-10 11:03 ` Jeff King
2009-02-10 11:29   ` Michael J Gruber
2009-02-10 11:31     ` Tuncer Ayaz
2009-02-10 11:45     ` Jeff King
2009-02-10 12:36       ` Michael J Gruber
2009-02-10 13:01         ` Jeff King
2009-02-10 15:58   ` Junio C Hamano [this message]
2009-02-10 18:10     ` Jeff King
2009-02-10 18:22       ` Jeff King
2009-02-10 19:11       ` Jeff King
2009-02-10 21:21         ` Tuncer Ayaz
2009-02-10 21:36           ` Jeff King
2009-02-10 22:25         ` Junio C Hamano
2009-02-10 22:52           ` Tuncer Ayaz
2009-02-10 22:55           ` Jeff King
2009-02-10 23:05             ` Junio C Hamano
2009-02-12  0:49               ` Jeff King
2009-02-10 23:52     ` Nanako Shiraishi
2009-02-11 21:24       ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2009-02-10 23:58 [RFC] New command: 'git snapshot' Ulrik Sverdrup
2009-02-11  0:08 ` [RFC/PATCH] shortstatus v1 Nanako Shiraishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwsbynv0o.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=tuncer.ayaz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).