RFH: git show HEAD:$SUBMODULE

RFH: git show HEAD:$SUBMODULE

[Johannes Schindelin]

Hi,

at the moment, 'show HEAD:$SUBMODULE' fails horribly, as git-show abuses 
the revision walker to parse the command line parameters, and the revision 
walker does not like a non-existing commit.

Instead, it would be nicer to show the user something like

	HEAD:$SUBMODULE
	submodule at commit $COMMIT_NAME

However, I have no clue how to go about getting that.  I want to avoid 
having to parse the parameters twice, but I also do not want to fsck up 
the revision walker...

Ideas?

Ciao,
Dscho

Re: RFH: git show HEAD:$SUBMODULE

[Junio C Hamano]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> at the moment, 'show HEAD:$SUBMODULE' fails horribly, as git-show abuses 
> the revision walker to parse the command line parameters, and the revision 
> walker does not like a non-existing commit.
>
> Instead, it would be nicer to show the user something like
>
> 	HEAD:$SUBMODULE
> 	submodule at commit $COMMIT_NAME
>
> However, I have no clue how to go about getting that.  I want to avoid 
> having to parse the parameters twice, but I also do not want to fsck up 
> the revision walker...
>
> Ideas?

This is not an idea but it falls into the same category as handling this
in a way different from the current code.

	$ cd Documentation
        $ git show HEAD:git.txt

You really shouldn't letting revision machinery to parse it if you want to
see these work in the way you want, because both in your example and in
the often asked-for "relative to cwd" example, what you are *asking for*
is not just an object name, but you are using the mechanism that is meant
to be used for one.

I personally think reusing the "object name" syntax for either of the
above usages is a mistake, though.  If HEAD:$submodule_path is a notation
for naming an object (which happens to resolve to a commit) and HEAD:git.txt
is a notation for naming a blob object that is found at the top level of
the tree-ish that can be called HEAD, they should retain the same meaning
throughout the system and "git show" shouldn't be messing with the
semantics of the notation.