From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Allow cloning an empty repository Date: Thu, 22 Jan 2009 17:24:27 -0800 Message-ID: <7vwscm4xx0.fsf@gitster.siamese.dyndns.org> References: <1232669252-21881-1-git-send-email-srabbelier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: Sverre Rabbelier X-From: git-owner@vger.kernel.org Fri Jan 23 02:26:14 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LQAoE-0005a5-QC for gcvg-git-2@gmane.org; Fri, 23 Jan 2009 02:26:11 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761273AbZAWBYk (ORCPT ); Thu, 22 Jan 2009 20:24:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760603AbZAWBYj (ORCPT ); Thu, 22 Jan 2009 20:24:39 -0500 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:50463 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761981AbZAWBYe (ORCPT ); Thu, 22 Jan 2009 20:24:34 -0500 Received: from localhost.localdomain (unknown [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id F243A93B7F; Thu, 22 Jan 2009 20:24:32 -0500 (EST) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTPSA id C5B7193B7C; Thu, 22 Jan 2009 20:24:29 -0500 (EST) In-Reply-To: <1232669252-21881-1-git-send-email-srabbelier@gmail.com> (Sverre Rabbelier's message of "Fri, 23 Jan 2009 01:07:32 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 96BBBB7E-E8EC-11DD-9CB5-5720C92D7133-77302942!a-sasl-fastnet.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Sverre Rabbelier writes: > diff --git a/builtin-clone.c b/builtin-clone.c > index f7e5a7b..d5bba0e 100644 > --- a/builtin-clone.c > +++ b/builtin-clone.c > @@ -522,14 +522,23 @@ int cmd_clone(int argc, const char **argv, const char *prefix) > option_upload_pack); > > refs = transport_get_remote_refs(transport); > - transport_fetch_refs(transport, refs); > + if(refs) > + transport_fetch_refs(transport, refs); Thanks. I think the basic idea is Ok, but is it a reliable check at this point to see if (refs == NULL) to tell if the target repository is an empty one? I am mostly worried about a failure case (connected but couldn't get the refs, or perhaps connection failed to start). If you get a NULL in such a case you may end up saying "oh you cloned a void" when you should say "nah, such a remote repository does not exist". If transport_get_remote_refs() dies without returning NULL, that would be sufficient, but I didn't check.