From: Junio C Hamano <gitster@pobox.com>
To: "Philippe Bruhat (BooK)" <book@cpan.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Git.pm: let a "false" Directory parameter (such as "0") be used correctly by the constructor"
Date: Thu, 01 Jan 2009 13:00:18 -0800 [thread overview]
Message-ID: <7vwsdeivx9.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1230510300-7854-1-git-send-email-book@cpan.org
"Philippe Bruhat (BooK)" <book@cpan.org> writes:
> ---
> perl/Git.pm | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
Lacks sign-off and description but otherwise looks good. Will queue to
'pu' to leave you a chance to re-send.
commit b29b1ae7442cd7c1c78e38b7d980905944ec31e0
Author: Philippe Bruhat (BooK) <book@cpan.org>
Date: Mon Dec 29 01:25:00 2008 +0100
Git.pm: correctly handle directory name that evaluates to "false"
The repository constructor mistakenly rewrote a Directory parameter that
Perl happens to evaluate to false (e.g. "0") to ".".
Thanks.
next prev parent reply other threads:[~2009-01-01 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 0:25 [PATCH] Git.pm: let a "false" Directory parameter (such as "0") be used correctly by the constructor" Philippe Bruhat (BooK)
2009-01-01 21:00 ` Junio C Hamano [this message]
2009-01-02 8:37 ` Philippe Bruhat (BooK)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwsdeivx9.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=book@cpan.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).