* [PATCH] Git.pm: let a "false" Directory parameter (such as "0") be used correctly by the constructor"
@ 2008-12-29 0:25 Philippe Bruhat (BooK)
2009-01-01 21:00 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Bruhat (BooK) @ 2008-12-29 0:25 UTC (permalink / raw)
To: git; +Cc: Philippe Bruhat (BooK)
---
perl/Git.pm | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index 8392a68..ad0f530 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -166,11 +166,12 @@ sub repository {
}
}
- if (not defined $opts{Repository} and not defined $opts{WorkingCopy}) {
- $opts{Directory} ||= '.';
+ if (not defined $opts{Repository} and not defined $opts{WorkingCopy}
+ and not defined $opts{Directory}) {
+ $opts{Directory} = '.';
}
- if ($opts{Directory}) {
+ if (defined $opts{Directory}) {
-d $opts{Directory} or throw Error::Simple("Directory not found: $!");
my $search = Git->repository(WorkingCopy => $opts{Directory});
--
1.6.0.3.517.g759a
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Git.pm: let a "false" Directory parameter (such as "0") be used correctly by the constructor"
2008-12-29 0:25 [PATCH] Git.pm: let a "false" Directory parameter (such as "0") be used correctly by the constructor" Philippe Bruhat (BooK)
@ 2009-01-01 21:00 ` Junio C Hamano
2009-01-02 8:37 ` Philippe Bruhat (BooK)
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2009-01-01 21:00 UTC (permalink / raw)
To: Philippe Bruhat (BooK); +Cc: git
"Philippe Bruhat (BooK)" <book@cpan.org> writes:
> ---
> perl/Git.pm | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
Lacks sign-off and description but otherwise looks good. Will queue to
'pu' to leave you a chance to re-send.
commit b29b1ae7442cd7c1c78e38b7d980905944ec31e0
Author: Philippe Bruhat (BooK) <book@cpan.org>
Date: Mon Dec 29 01:25:00 2008 +0100
Git.pm: correctly handle directory name that evaluates to "false"
The repository constructor mistakenly rewrote a Directory parameter that
Perl happens to evaluate to false (e.g. "0") to ".".
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Git.pm: let a "false" Directory parameter (such as "0") be used correctly by the constructor"
2009-01-01 21:00 ` Junio C Hamano
@ 2009-01-02 8:37 ` Philippe Bruhat (BooK)
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Bruhat (BooK) @ 2009-01-02 8:37 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Thu, Jan 01, 2009 at 01:00:18PM -0800, Junio C Hamano wrote:
> "Philippe Bruhat (BooK)" <book@cpan.org> writes:
>
> > ---
> > perl/Git.pm | 7 ++++---
> > 1 files changed, 4 insertions(+), 3 deletions(-)
>
> Lacks sign-off and description but otherwise looks good. Will queue to
> 'pu' to leave you a chance to re-send.
Yeah, I noticed the lack of Sign-off right after sending. I'll re-send.
--
Philippe Bruhat (BooK)
A reputation is only as good as the truth beneath it, if any.
(Moral from Groo The Wanderer #91 (Epic))
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-02 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-29 0:25 [PATCH] Git.pm: let a "false" Directory parameter (such as "0") be used correctly by the constructor" Philippe Bruhat (BooK)
2009-01-01 21:00 ` Junio C Hamano
2009-01-02 8:37 ` Philippe Bruhat (BooK)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).