git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Trent Piepho <tpiepho@freescale.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-email: Fix Pine address book parsing
Date: Wed, 26 Nov 2008 11:46:15 -0800	[thread overview]
Message-ID: <7vwseqfeyg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: Pine.LNX.4.64.0811260243440.5161@t2.domain.actdsltmp

Trent Piepho <tpiepho@freescale.com> writes:

> ...  There isn't any code that just does line wrapping. 
> The code that prints out a address book entry will at various points check
> if it should output a newline.  And it whatever it prints after those
> points isn't allowed to start with space.  The code that reads the entries
> eats all the spaces before and after each field.  If long comments are
> wrapped, it will change "a   b" into "a\n :  b\n" and effectively does 
> s/^ +: / /; when reading it back.  But email address don't get wrapped
> that way so we don't need to care about the ':'.

I never was worried about eating and losing the leading space that was
used only to signal the continuation line, but was wondering if we need to
insert an artificial space in place of the newline we are eating, but it
appears that we can say with confidence that worry is unfounded.

Will queue.  Thanks.

      reply	other threads:[~2008-11-26 19:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26  2:55 [PATCH] send-email: Fix Pine address book parsing Trent Piepho
2008-11-26  4:58 ` Junio C Hamano
2008-11-26  5:59   ` Trent Piepho
2008-11-26  6:44     ` Junio C Hamano
2008-11-26 11:13       ` Trent Piepho
2008-11-26 19:46         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwseqfeyg.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=tpiepho@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).