From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] send-email: Fix Pine address book parsing Date: Wed, 26 Nov 2008 11:46:15 -0800 Message-ID: <7vwseqfeyg.fsf@gitster.siamese.dyndns.org> References: <1227668100-5563-1-git-send-email-tpiepho@freescale.com> <7vod03hyna.fsf@gitster.siamese.dyndns.org> <7vy6z7gf4x.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org To: Trent Piepho X-From: git-owner@vger.kernel.org Wed Nov 26 20:48:10 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1L5QMh-00055a-Hu for gcvg-git-2@gmane.org; Wed, 26 Nov 2008 20:47:59 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752713AbYKZTqm (ORCPT ); Wed, 26 Nov 2008 14:46:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752690AbYKZTql (ORCPT ); Wed, 26 Nov 2008 14:46:41 -0500 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:50327 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491AbYKZTql (ORCPT ); Wed, 26 Nov 2008 14:46:41 -0500 Received: from localhost.localdomain (unknown [127.0.0.1]) by b-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTP id A584A178A2; Wed, 26 Nov 2008 14:46:40 -0500 (EST) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by b-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTPSA id 2B57D178B4; Wed, 26 Nov 2008 14:46:16 -0500 (EST) User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: F1F2509C-BBF2-11DD-881B-F83E113D384A-77302942!a-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Trent Piepho writes: > ... There isn't any code that just does line wrapping. > The code that prints out a address book entry will at various points check > if it should output a newline. And it whatever it prints after those > points isn't allowed to start with space. The code that reads the entries > eats all the spaces before and after each field. If long comments are > wrapped, it will change "a b" into "a\n : b\n" and effectively does > s/^ +: / /; when reading it back. But email address don't get wrapped > that way so we don't need to care about the ':'. I never was worried about eating and losing the leading space that was used only to signal the continuation line, but was wondering if we need to insert an artificial space in place of the newline we are eating, but it appears that we can say with confidence that worry is unfounded. Will queue. Thanks.