From: Junio C Hamano <gitster@pobox.com>
To: Gustaf Hendeby <hendeby@isy.liu.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Document clarification: gitmodules, gitattributes
Date: Sun, 31 Aug 2008 09:38:40 -0700 [thread overview]
Message-ID: <7vwshx2l7z.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1220198427-13017-1-git-send-email-hendeby@isy.liu.se> (Gustaf Hendeby's message of "Sun, 31 Aug 2008 18:00:27 +0200")
Gustaf Hendeby <hendeby@isy.liu.se> writes:
> The SYNOPSIS section of gitattibutes and gitmodule fail to clearly
> specify the name of the in tree files used. This patch brings in the
> initial `.' and the fact that the `.gitmodules' file should reside at
> the top-level of the working tree.
>
> Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
> ---
>
> If this patch isn't accepted, the reverse changes should be made to
> the gitignore documentation.
The sole reason they lacked the initial "." was because AsciiDOC
mishandled ".gitmodules" that began the line; we used to have the dot but
removed it as a workaround because we couldn't find a good solution by
tweaking the mark-up.
By prefixing "$GIT_FOOBAR/" in front of them, your patch makes the issue
go away while conveying the fact that it has to be at the toplevel of the
work tree, not anywhere in the tree. Very nice.
prev parent reply other threads:[~2008-08-31 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 16:00 [PATCH] Document clarification: gitmodules, gitattributes Gustaf Hendeby
2008-08-31 16:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwshx2l7z.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hendeby@isy.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).